mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2026-05-07 07:08:04 +02:00
radv: clarify that copy prop is required for correctness after D16 opt
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/work_items/14854 Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/40871>
This commit is contained in:
parent
51ba9b956a
commit
21bdc7105d
1 changed files with 4 additions and 2 deletions
|
|
@ -581,8 +581,10 @@ radv_postprocess_nir(struct radv_device *device, const struct radv_graphics_stat
|
|||
bool run_copy_prop = false;
|
||||
NIR_PASS(run_copy_prop, stage->nir, nir_opt_16bit_tex_image, &opt_16bit_options);
|
||||
|
||||
/* Optimizing 16bit texture/image dests leaves scalar moves that stops
|
||||
* nir_opt_vectorize from vectorzing the alu uses of them.
|
||||
/* Optimizing 16bit texture/image dests leaves scalar moves that need to be removed
|
||||
* before the next alu nir_lower_alu_width, otherwise we might end up with invalid swizzles
|
||||
* in the backend.
|
||||
* It also allows nir_opt_vectorize to make more progress.
|
||||
*/
|
||||
if (run_copy_prop) {
|
||||
NIR_PASS(_, stage->nir, nir_opt_copy_prop);
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue