fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-23 06:50:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

radv: Fix redundant subpass barriers due to erroneous comparison

Browse source 
We accidentally compared the stencil layout to the color/depth layout.

Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16663>
This commit is contained in:
Tatsuyuki Ishi 2022-05-23 19:14:25 +09:00 • committed by Marge Bot
parent 1a8b03732f
commit 211db6d333
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/amd/vulkan/radv_pass.c
View file

@ -142,7 +142,7 @@ radv_render_pass_add_implicit_deps(struct radv_render_pass *pass)
*/ */
if (pass_att->first_subpass_idx == i && !subpass->has_ingoing_dep && if (pass_att->first_subpass_idx == i && !subpass->has_ingoing_dep &&
((subpass_att->layout != initial_layout) || ((subpass_att->layout != initial_layout) ||
(subpass_att->layout != stencil_initial_layout))) { (subpass_att->stencil_layout != stencil_initial_layout))) {
add_ingoing_dep = true; add_ingoing_dep = true;
} }
@ -152,7 +152,7 @@ radv_render_pass_add_implicit_deps(struct radv_render_pass *pass)
*/ */
if (pass_att->last_subpass_idx == i && !subpass->has_outgoing_dep && if (pass_att->last_subpass_idx == i && !subpass->has_outgoing_dep &&
((subpass_att->layout != final_layout) || ((subpass_att->layout != final_layout) ||
(subpass_att->layout != stencil_final_layout))) { (subpass_att->stencil_layout != stencil_final_layout))) {
add_outgoing_dep = true; add_outgoing_dep = true;
} }
} }