fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-21 09:20:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

iris/gen12: Work around push constant corruption on context switch.

Browse source 
This has been confirmed to fix sporadic graphics corruption on Gen12
platforms for a number of workloads (including Heaven, Valley and
CS:GO among others).  Corruption seems to occur during context switch
fairly consistently, but unfortunately this problem doesn't seem to be
documented.  Until the hardware team comes up with a better
workaround, fix the problem by reemitting constants at the beginning
of each batch.

No corruption has been observed so far in GL due to preemption,
however this is a possibility to keep in mind, it may be necessary to
disable preemption in addition to this patch in order to fully address
this problem (see also 81201e4617).

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4412
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4454
Cc: mesa-stable
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
This commit is contained in:
Francisco Jerez 2021-03-29 12:26:41 -07:00
parent aea6f8effc
commit 20e2c7308f
1 changed files with 17 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/gallium/drivers/iris/iris_state.c
View file

@ -6584,9 +6584,25 @@ iris_upload_render_state(struct iris_context *ice,
iris_use_pinned_bo(batch, ice->state.binder.bo, false, iris_use_pinned_bo(batch, ice->state.binder.bo, false,
IRIS_DOMAIN_NONE); IRIS_DOMAIN_NONE);
if (!batch->contains_draw) {
if (GFX_VER == 12) {
/* Re-emit constants when starting a new batch buffer in order to
* work around push constant corruption on context switch.
*
* XXX - Provide hardware spec quotation when available.
*/
ice->state.stage_dirty |= (IRIS_STAGE_DIRTY_CONSTANTS_VS |
IRIS_STAGE_DIRTY_CONSTANTS_TCS |
IRIS_STAGE_DIRTY_CONSTANTS_TES |
IRIS_STAGE_DIRTY_CONSTANTS_GS |
IRIS_STAGE_DIRTY_CONSTANTS_FS);
}
batch->contains_draw = true;
}
if (!batch->contains_draw_with_next_seqno) { if (!batch->contains_draw_with_next_seqno) {
iris_restore_render_saved_bos(ice, batch, draw); iris_restore_render_saved_bos(ice, batch, draw);
batch->contains_draw_with_next_seqno = batch->contains_draw = true; batch->contains_draw_with_next_seqno = true;
} }
iris_upload_dirty_render_state(ice, batch, draw); iris_upload_dirty_render_state(ice, batch, draw);