From 2089ce9ffcc0d06ff263b338c0ebca36cef65a79 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20Ondra=C4=8Dka?= Date: Thu, 13 Jul 2023 10:57:11 +0200 Subject: [PATCH] r300: update RV370 failures This was missed in 0bf6dcb785ce82006f9757217153735e39127834 There is a loop which iterates over a temp array. NIR optimization moves the real work out of the loop and what remains are just ALU ops with undefs. So after converting undefs to zero, the ALU ops are optimized out and DCE kills the loop. This is a good thing in general and we don't fail the linking due to the loop presence. However than we hit the shader constants and ALU limits later :-( So from dEQP POW we go from NotSupported to Fail. Fixes: 0bf6dcb785ce82006f9757217153735e39127834 Part-of: (cherry picked from commit 0a2a7bfd19b66a4bd29e1ef112659a2976e6d61c) --- .pick_status.json | 2 +- src/gallium/drivers/r300/ci/r300-rv370-fails.txt | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.pick_status.json b/.pick_status.json index 0baef1ecede..8a18f09fdf5 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -24,7 +24,7 @@ "description": "r300: update RV370 failures", "nominated": true, "nomination_type": 1, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "0bf6dcb785ce82006f9757217153735e39127834", "notes": null diff --git a/src/gallium/drivers/r300/ci/r300-rv370-fails.txt b/src/gallium/drivers/r300/ci/r300-rv370-fails.txt index 481fbb9e39c..4097cfeb002 100644 --- a/src/gallium/drivers/r300/ci/r300-rv370-fails.txt +++ b/src/gallium/drivers/r300/ci/r300-rv370-fails.txt @@ -32,6 +32,9 @@ dEQP-GLES2.functional.shaders.functions.control_flow.return_after_continue_fragm dEQP-GLES2.functional.shaders.functions.control_flow.return_after_continue_vertex,Fail dEQP-GLES2.functional.shaders.indexing.tmp_array.float_const_write_dynamic_read_fragment,Fail dEQP-GLES2.functional.shaders.indexing.tmp_array.float_const_write_dynamic_read_vertex,Fail +dEQP-GLES2.functional.shaders.indexing.tmp_array.vec2_const_write_dynamic_loop_read_fragment,Fail +dEQP-GLES2.functional.shaders.indexing.tmp_array.vec3_const_write_dynamic_loop_read_fragment,Fail +dEQP-GLES2.functional.shaders.indexing.tmp_array.vec4_const_write_dynamic_loop_read_fragment,Fail dEQP-GLES2.functional.shaders.indexing.tmp_array.vec2_const_write_dynamic_read_fragment,Fail dEQP-GLES2.functional.shaders.indexing.tmp_array.vec2_const_write_dynamic_read_vertex,Fail dEQP-GLES2.functional.shaders.indexing.tmp_array.vec3_const_write_dynamic_read_fragment,Fail