From 2036a2c5c5ed63439d267b781c01e2edf7c15b74 Mon Sep 17 00:00:00 2001 From: Rhys Perry Date: Fri, 12 Nov 2021 10:28:24 +0000 Subject: [PATCH] radv: use load_shared2_amd/store_shared2_amd MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit fossil-db (Sienna Cichlid): Totals from 376 (0.23% of 162293) affected shaders: MaxWaves: 9620 -> 9596 (-0.25%); split: +0.08%, -0.33% Instrs: 207533 -> 203901 (-1.75%); split: -1.76%, +0.01% CodeSize: 1130904 -> 1106420 (-2.16%); split: -2.17%, +0.01% VGPRs: 14016 -> 14120 (+0.74%); split: -0.34%, +1.08% Latency: 2143281 -> 2132212 (-0.52%); split: -0.56%, +0.05% InvThroughput: 389116 -> 387990 (-0.29%); split: -0.34%, +0.05% VClause: 4483 -> 4485 (+0.04%); split: -0.11%, +0.16% SClause: 5780 -> 5778 (-0.03%); split: -0.17%, +0.14% Copies: 15319 -> 15331 (+0.08%); split: -0.53%, +0.61% Branches: 5561 -> 5563 (+0.04%) PreSGPRs: 11776 -> 11775 (-0.01%) PreVGPRs: 11393 -> 11497 (+0.91%); split: -0.13%, +1.04% Signed-off-by: Rhys Perry Reviewed-by: Timur Kristóf Part-of: --- src/amd/vulkan/radv_pipeline.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 7a139f73289..703cb7a3489 100644 --- a/src/amd/vulkan/radv_pipeline.c +++ b/src/amd/vulkan/radv_pipeline.c @@ -4351,6 +4351,10 @@ radv_create_shaders(struct radv_pipeline *pipeline, struct radv_pipeline_layout nir_var_mem_shared | nir_var_mem_global, .callback = mem_vectorize_callback, .robust_modes = 0, + /* On GFX6, read2/write2 is out-of-bounds if the offset register is negative, even if + * the final offset is not. + */ + .has_shared2_amd = device->physical_device->rad_info.chip_class >= GFX7, }; if (device->robust_buffer_access2) {