From 1f294e808c359c9195b898d0a97d61a7e340b545 Mon Sep 17 00:00:00 2001 From: Erik Faye-Lund Date: Tue, 3 Dec 2024 19:44:09 +0100 Subject: [PATCH] panvk: expose KHR_dedicated_allocation Caterina already implemented this in ed64fa034b0 ("panvk: never prefer or require dedicated allocation for buffers") and dbdaefb6edf ("panvk: never require dedicated allocation for images"), so let's flip the switch. We pass 4505 of the CTS tests, and fail a single one. Let's mark that one as an expected failure and move on for now. Reviewed-by: Chia-I Wu Reviewed-by: Boris Brezillon Part-of: --- docs/features.txt | 2 +- src/panfrost/ci/panfrost-g610-fails.txt | 2 ++ src/panfrost/vulkan/panvk_physical_device.c | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/features.txt b/docs/features.txt index 8fc9ae78888..fabc421aedb 100644 --- a/docs/features.txt +++ b/docs/features.txt @@ -429,7 +429,7 @@ Vulkan 1.1 -- all DONE: anv, lvp, nvk, radv, tu, vn VK_KHR_16bit_storage DONE (anv, dzn, hasvk, lvp, nvk, panvk, radv, tu/a650+, v3dv, vn) VK_KHR_bind_memory2 DONE (anv, dzn, hasvk, lvp, nvk, panvk, pvr, radv, tu, v3dv, vn) - VK_KHR_dedicated_allocation DONE (anv, dzn, hasvk, lvp, nvk, radv, tu, v3dv, vn) + VK_KHR_dedicated_allocation DONE (anv, dzn, hasvk, lvp, nvk, panvk, radv, tu, v3dv, vn) VK_KHR_descriptor_update_template DONE (anv, dzn, hasvk, lvp, nvk, panvk, radv, tu, v3dv, vn) VK_KHR_device_group DONE (anv, dzn, hasvk, lvp, nvk, panvk, tu, v3dv, vn) VK_KHR_device_group_creation DONE (anv, dzn, hasvk, lvp, nvk, panvk, tu, v3dv, vn) diff --git a/src/panfrost/ci/panfrost-g610-fails.txt b/src/panfrost/ci/panfrost-g610-fails.txt index 99c6a4f4e62..a70db18336a 100644 --- a/src/panfrost/ci/panfrost-g610-fails.txt +++ b/src/panfrost/ci/panfrost-g610-fails.txt @@ -337,6 +337,8 @@ dEQP-VK.renderpass2.suballocation.subpass_dependencies.late_fragment_tests.rende dEQP-VK.renderpass2.suballocation.subpass_dependencies.late_fragment_tests.render_size_64_64.subpass_count_5.d24_unorm_s8_uint,Fail dEQP-VK.renderpass2.suballocation.subpass_dependencies.late_fragment_tests.render_size_64_64.subpass_count_5.d32_sfloat_s8_uint,Fail +dEQP-VK.renderpass.dedicated_allocation.attachment_allocation.input_output.63,Fail + dEQP-VK.spirv_assembly.instruction.graphics.cross_stage.basic_type.no_perspective,Fail dEQP-VK.spirv_assembly.instruction.graphics.cross_stage.interface_blocks.no_perspective,Fail diff --git a/src/panfrost/vulkan/panvk_physical_device.c b/src/panfrost/vulkan/panvk_physical_device.c index 2549e3ff577..7f0b635dbc5 100644 --- a/src/panfrost/vulkan/panvk_physical_device.c +++ b/src/panfrost/vulkan/panvk_physical_device.c @@ -192,6 +192,7 @@ get_device_extensions(const struct panvk_physical_device *device, .KHR_buffer_device_address = true, .KHR_copy_commands2 = true, .KHR_create_renderpass2 = true, + .KHR_dedicated_allocation = true, .KHR_device_group = true, .KHR_descriptor_update_template = true, .KHR_driver_properties = true,