fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-24 21:50:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

pan/bi: Optimize split of collect

Browse source 
Required to get decent codegen from UBO pushing.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16585>
This commit is contained in:
Alyssa Rosenzweig 2022-05-12 13:10:57 -04:00 • committed by Marge Bot
parent 4a8bde2190
commit 1f25f78a9f
1 changed files with 38 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
src/panfrost/bifrost/bi_opt_copy_prop.c
View file

@ -23,6 +23,7 @@
*/
#include "compiler.h"
#include "bi_builder.h"
/* A simple scalar-only SSA-based copy-propagation pass. TODO: vectors */
@ -48,6 +49,43 @@ bi_reads_fau(bi_instr *ins)
void
bi_opt_copy_prop(bi_context *ctx)
{
/* Chase SPLIT of COLLECT. Instruction selection usually avoids this
* pattern (due to the split cache), but it is inevitably generated by
* the UBO pushing pass.
*/
bi_instr **collects = calloc(sizeof(bi_instr *), ctx->ssa_alloc);
bi_foreach_instr_global_safe(ctx, I) {
if (I->op == BI_OPCODE_COLLECT_I32) {
/* Rewrite trivial collects while we're at it */
if (I->nr_srcs == 1)
I->op = BI_OPCODE_MOV_I32;
if (bi_is_ssa(I->dest[0]))
collects[I->dest[0].value] = I;
} else if (I->op == BI_OPCODE_SPLIT_I32) {
/* Rewrite trivial splits while we're at it */
if (I->nr_dests == 1)
I->op = BI_OPCODE_MOV_I32;
if (!bi_is_ssa(I->src[0]))
continue;
bi_instr *collect = collects[I->src[0].value];
if (!collect)
continue;
/* Lower the split to moves, copyprop cleans up */
bi_builder b = bi_init_builder(ctx, bi_before_instr(I));
for (unsigned d = 0; d < I->nr_dests; ++d)
bi_mov_i32_to(&b, I->dest[d], collect->src[d]);
bi_remove_instruction(I);
}
}
free(collects);
bi_index *replacement = calloc(sizeof(bi_index), ctx->ssa_alloc);
bi_foreach_instr_global_safe(ctx, ins) {