fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-24 21:50:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

panfrost: Only run batch debug when specifically asked

Browse source 
It's expensive and in a hot path; even for general debug builds we won't
need this, only if we're specifically hacking on batch code.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5202>
This commit is contained in:
Alyssa Rosenzweig 2020-05-22 21:49:06 -04:00 • committed by Marge Bot
parent 4c5d1e2860
commit 1d647b1c48
1 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/gallium/drivers/panfrost/pan_job.c
View file

@ -146,7 +146,7 @@ panfrost_freeze_batch(struct panfrost_batch *batch)
}
}
#ifndef NDEBUG
#ifdef PAN_BATCH_DEBUG
static bool panfrost_batch_is_frozen(struct panfrost_batch *batch)
{
struct panfrost_context *ctx = batch->ctx;
@ -169,7 +169,9 @@ panfrost_free_batch(struct panfrost_batch *batch)
if (!batch)
return;
#ifdef PAN_BATCH_DEBUG
assert(panfrost_batch_is_frozen(batch));
#endif
hash_table_foreach(batch->bos, entry)
panfrost_bo_unreference((struct panfrost_bo *)entry->key);
@ -192,7 +194,7 @@ panfrost_free_batch(struct panfrost_batch *batch)
ralloc_free(batch);
}
#ifndef NDEBUG
#ifdef PAN_BATCH_DEBUG
static bool
panfrost_dep_graph_contains_batch(struct panfrost_batch *root,
struct panfrost_batch *batch)
@ -228,8 +230,10 @@ panfrost_batch_add_dep(struct panfrost_batch *batch,
return;
}
#ifdef PAN_BATCH_DEBUG
/* Make sure the dependency graph is acyclic. */
assert(!panfrost_dep_graph_contains_batch(newdep->batch, batch));
#endif
panfrost_batch_fence_reference(newdep);
util_dynarray_append(&batch->dependencies,
@ -390,7 +394,7 @@ panfrost_gc_fences(struct panfrost_context *ctx)
}
}
#ifndef NDEBUG
#ifdef PAN_BATCH_DEBUG
static bool
panfrost_batch_in_readers(struct panfrost_batch *batch,
struct panfrost_bo_access *access)
@ -511,10 +515,12 @@ panfrost_batch_update_bo_access(struct panfrost_batch *batch,
/* We already accessed this BO before, so we should already be
* in the reader array.
*/
#ifdef PAN_BATCH_DEBUG
if (already_accessed) {
assert(panfrost_batch_in_readers(batch, access));
return;
}
#endif
/* Previous access was a read and we want to read this BO.
* Add ourselves to the readers array and add a dependency on