fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-21 22:20:14 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

i965/nir: do int64 lowering before optimization

Browse source 
Otherwise loop unrolling will fail to see the actual cost of
the unrolling operations when the loop body contains 64-bit integer
instructions, and very specially when the divmod64 lowering applies,
since its lowering is quite expensive.

Without this change, some in-development CTS tests for int64
get stuck forever trying to register allocate a shader with
over 50K SSA values. The large number of SSA values is the result
of NIR first unrolling multiple seemingly simple loops that involve
int64 instructions, only to then lower these instructions to produce
a massive pile of code (due to the divmod64 lowering in the unrolled
instructions).

With this change, loop unrolling will see the loops with the int64
code already lowered and will realize that it is too expensive to
unroll.

v2: Run nir_algebraic first so we can hopefully get rid of some of
    the int64 instructions before we even attempt to lower them.

Reviewed-by: Matt Turner <mattst88@gmail.com>
This commit is contained in:
Iago Toral Quiroga 2017-12-01 13:46:23 +01:00
parent 02a6d901ee
commit 1d20001d97
1 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/intel/compiler/brw_nir.c
View file

@ -634,6 +634,18 @@ brw_preprocess_nir(const struct brw_compiler *compiler, nir_shader *nir)
OPT(nir_split_var_copies);
/* Run opt_algebraic before int64 lowering so we can hopefully get rid
* of some int64 instructions.
*/
OPT(nir_opt_algebraic);
/* Lower int64 instructions before nir_optimize so that loop unrolling
* sees their actual cost.
*/
nir_lower_int64(nir, nir_lower_imul64 |
nir_lower_isign64 |
nir_lower_divmod64);
nir = brw_nir_optimize(nir, compiler, is_scalar);
if (is_scalar) {
@ -661,10 +673,6 @@ brw_preprocess_nir(const struct brw_compiler *compiler, nir_shader *nir)
brw_nir_no_indirect_mask(compiler, nir->info.stage);
nir_lower_indirect_derefs(nir, indirect_mask);
nir_lower_int64(nir, nir_lower_imul64 |
nir_lower_isign64 |
nir_lower_divmod64);
/* Get rid of split copies */
nir = brw_nir_optimize(nir, compiler, is_scalar);