fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-26 04:10:09 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

ac: document RELEASE_MEM limitation with PS_DONE/CS_DONE on gfx6-11

Browse source 
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38602>
This commit is contained in:
Marek Olšák 2025-11-21 17:41:01 -05:00 • committed by Marge Bot
parent 406e6e094a
commit 1c3e7e4ca0
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/amd/common/ac_cmdbuf_cp.c
View file

@ -191,6 +191,9 @@ ac_emit_cp_release_mem_pws(struct ac_cmdbuf *cs, ASSERTED enum amd_gfx_level gfx
uint32_t gcr_cntl)
{
assert(gfx_level >= GFX11 && ip_type == AMD_IP_GFX);
/* Only GFX12+ supports GCR ops with PS_DONE & CS_DONE in RELEASE_MEM. */
assert(gfx_level >= GFX12 || !gcr_cntl || (event_type != V_028A90_PS_DONE &&
event_type != V_028A90_CS_DONE));
/* Extract GCR_CNTL fields because the encoding is different in RELEASE_MEM. */
assert(G_586_GLI_INV(gcr_cntl) == 0);
@ -445,6 +448,10 @@ ac_emit_cp_release_mem(struct ac_cmdbuf *cs, enum amd_gfx_level gfx_level,
uint32_t int_sel, uint32_t data_sel, uint64_t va,
uint32_t new_fence, uint64_t eop_bug_va)
{
/* Only GFX12+ supports GCR ops with PS_DONE & CS_DONE in RELEASE_MEM. */
assert(gfx_level >= GFX12 || !event_flags || (event != V_028A90_PS_DONE &&
event != V_028A90_CS_DONE));
const bool is_mec = gfx_level >= GFX7 && ip_type == AMD_IP_COMPUTE;
/* GFX7 CP DMA: any use of CP_DMA.DST_SEL=TC must be avoided when EOS packets are used.