fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-04 11:58:10 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

vulkan/wsi/display: set pDisplay to NULL on error

Browse source 
the spec for vkGetDrmDisplayEXT says:

  "If there is no VkDisplayKHR corresponding to the connectorId on the
   physicalDevice, the returning display must be set to VK_NULL_HANDLE.
   The provided drmFd must correspond to the one owned by the physicalDevice.
   If not, the error code VK_ERROR_UNKNOWN must be returned. (...)
   The given connectorId must be a resource owned by the provided drmFd.
   If not, the error code VK_ERROR_UNKNOWN must be returned"

We were only setting the display pointer to VK_NULL_HANDLE if the provided
drmFd was valid, however, there are CTS tests checking that it is also set
to NULL when it is not.

Fixes the following test on all drivers exposing EXT_acquire_drm_display
(tested with Intel and V3DV):
dEQP-VK.wsi.acquire_drm_display.acquire_drm_display_invalid_fd

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22283>
This commit is contained in:
Iago Toral Quiroga 2023-04-04 12:25:11 +02:00 • committed by Marge Bot
parent d28cf0dbd5
commit 1bbbdbe666
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/vulkan/wsi/wsi_common_display.c
View file

@ -3172,8 +3172,10 @@ wsi_GetDrmDisplayEXT(VkPhysicalDevice physicalDevice,
VK_FROM_HANDLE(vk_physical_device, pdevice, physicalDevice);
struct wsi_device *wsi_device = pdevice->wsi_device;
if (!wsi_device_matches_drm_fd(wsi_device, drmFd))
if (!wsi_device_matches_drm_fd(wsi_device, drmFd)) {
*pDisplay = VK_NULL_HANDLE;
return VK_ERROR_UNKNOWN;
}
struct wsi_display_connector *connector =
wsi_display_get_connector(wsi_device, drmFd, connectorId);