mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2026-05-08 11:18:08 +02:00
fix broken two-sided stencil
This commit is contained in:
parent
43e902f774
commit
1b43babfb1
15 changed files with 49 additions and 24 deletions
|
|
@ -977,7 +977,6 @@ init_attrib_groups(GLcontext *ctx)
|
|||
/* Miscellaneous */
|
||||
ctx->NewState = _NEW_ALL;
|
||||
ctx->ErrorValue = (GLenum) GL_NO_ERROR;
|
||||
ctx->_Facing = 0;
|
||||
|
||||
return GL_TRUE;
|
||||
}
|
||||
|
|
|
|||
|
|
@ -3032,12 +3032,6 @@ struct __GLcontextRec
|
|||
|
||||
struct gl_list_extensions ListExt; /**< driver dlist extensions */
|
||||
|
||||
|
||||
GLuint _Facing; /**< This is a hack for 2-sided stencil test.
|
||||
*
|
||||
* We don't have a better way to communicate this value from
|
||||
* swrast_setup to swrast. */
|
||||
|
||||
/** \name For debugging/development only */
|
||||
/*@{*/
|
||||
GLboolean FirstTimeCurrent;
|
||||
|
|
|
|||
|
|
@ -141,6 +141,7 @@ NAME(line)(GLcontext *ctx, const SWvertex *v0, const SWvertex *v1)
|
|||
return;
|
||||
|
||||
INIT_SPAN(line.span, GL_LINE, 0, 0, SPAN_XY | SPAN_COVERAGE);
|
||||
line.span.facing = swrast->PointLineFacing;
|
||||
|
||||
line.xAdj = line.dx / line.len * line.halfWidth;
|
||||
line.yAdj = line.dy / line.len * line.halfWidth;
|
||||
|
|
|
|||
|
|
@ -78,7 +78,7 @@
|
|||
GLfloat texWidth[FRAG_ATTRIB_MAX];
|
||||
GLfloat texHeight[FRAG_ATTRIB_MAX];
|
||||
#endif
|
||||
GLfloat bf = SWRAST_CONTEXT(ctx)->_BackfaceSign;
|
||||
GLfloat bf = SWRAST_CONTEXT(ctx)->_BackfaceCullSign;
|
||||
|
||||
(void) swrast;
|
||||
|
||||
|
|
@ -116,6 +116,7 @@
|
|||
majDx = vMax->win[0] - vMin->win[0];
|
||||
majDy = vMax->win[1] - vMin->win[1];
|
||||
|
||||
/* front/back-face determination and cullling */
|
||||
{
|
||||
const GLfloat botDx = vMid->win[0] - vMin->win[0];
|
||||
const GLfloat botDy = vMid->win[1] - vMin->win[1];
|
||||
|
|
@ -124,6 +125,8 @@
|
|||
if (area * bf < 0 || area == 0 || IS_INF_OR_NAN(area))
|
||||
return;
|
||||
ltor = (GLboolean) (area < 0.0F);
|
||||
|
||||
span.facing = area * swrast->_BackfaceSign > 0.0F;
|
||||
}
|
||||
|
||||
/* Plane equation setup:
|
||||
|
|
|
|||
|
|
@ -117,8 +117,8 @@ _swrast_update_rasterflags( GLcontext *ctx )
|
|||
|
||||
|
||||
/**
|
||||
* Examine polycon culls tate to compute the _BackfaceSign field.
|
||||
* _BackfaceSign will be 0 if no culling, -1 if culling back-faces,
|
||||
* Examine polycon culls tate to compute the _BackfaceCullSign field.
|
||||
* _BackfaceCullSign will be 0 if no culling, -1 if culling back-faces,
|
||||
* and 1 if culling front-faces. The Polygon FrontFace state also
|
||||
* factors in.
|
||||
*/
|
||||
|
|
@ -149,10 +149,15 @@ _swrast_update_polygon( GLcontext *ctx )
|
|||
backface_sign = 0.0;
|
||||
}
|
||||
|
||||
SWRAST_CONTEXT(ctx)->_BackfaceSign = backface_sign;
|
||||
SWRAST_CONTEXT(ctx)->_BackfaceCullSign = backface_sign;
|
||||
|
||||
/* This is for front/back-face determination, but not for culling */
|
||||
SWRAST_CONTEXT(ctx)->_BackfaceSign
|
||||
= (ctx->Polygon.FrontFace == GL_CW) ? -1.0 : 1.0;
|
||||
}
|
||||
|
||||
|
||||
|
||||
/**
|
||||
* Update the _PreferPixelFog field to indicate if we need to compute
|
||||
* fog blend factors (from the fog coords) per-fragment.
|
||||
|
|
@ -720,6 +725,12 @@ _swrast_ResetLineStipple( GLcontext *ctx )
|
|||
SWRAST_CONTEXT(ctx)->StippleCounter = 0;
|
||||
}
|
||||
|
||||
void
|
||||
_swrast_SetFacing(GLcontext *ctx, GLuint facing)
|
||||
{
|
||||
SWRAST_CONTEXT(ctx)->PointLineFacing = facing;
|
||||
}
|
||||
|
||||
void
|
||||
_swrast_allow_vertex_fog( GLcontext *ctx, GLboolean value )
|
||||
{
|
||||
|
|
|
|||
|
|
@ -128,7 +128,8 @@ typedef struct
|
|||
* _swrast_validate_derived():
|
||||
*/
|
||||
GLbitfield _RasterMask;
|
||||
GLfloat _BackfaceSign;
|
||||
GLfloat _BackfaceSign; /** +1 or -1 */
|
||||
GLfloat _BackfaceCullSign; /** +1, 0, or -1 */
|
||||
GLboolean _PreferPixelFog; /* Compute fog blend factor per fragment? */
|
||||
GLboolean _AnyTextureCombine;
|
||||
GLboolean _FogEnabled;
|
||||
|
|
@ -151,6 +152,7 @@ typedef struct
|
|||
/* Working values:
|
||||
*/
|
||||
GLuint StippleCounter; /**< Line stipple counter */
|
||||
GLuint PointLineFacing;
|
||||
GLbitfield NewState;
|
||||
GLuint StateChanges;
|
||||
GLenum Primitive; /* current primitive being drawn (ala glBegin) */
|
||||
|
|
|
|||
|
|
@ -118,7 +118,7 @@ init_machine(GLcontext *ctx, struct gl_program_machine *machine,
|
|||
|
||||
if (ctx->Shader.CurrentProgram) {
|
||||
/* Store front/back facing value in register FOGC.Y */
|
||||
machine->Attribs[FRAG_ATTRIB_FOGC][col][1] = (GLfloat) ctx->_Facing;
|
||||
machine->Attribs[FRAG_ATTRIB_FOGC][col][1] = (GLfloat) span->facing;
|
||||
}
|
||||
|
||||
machine->CurElement = col;
|
||||
|
|
|
|||
|
|
@ -317,6 +317,9 @@ NAME( GLcontext *ctx, const SWvertex *vert0, const SWvertex *vert1 )
|
|||
span.attrStepX[FRAG_ATTRIB_WPOS][3] = 0.0F;
|
||||
span.attrStepY[FRAG_ATTRIB_WPOS][3] = 0.0F;
|
||||
|
||||
span.facing = swrast->PointLineFacing;
|
||||
|
||||
|
||||
/*
|
||||
* Draw
|
||||
*/
|
||||
|
|
|
|||
|
|
@ -105,6 +105,7 @@ NAME ( GLcontext *ctx, const SWvertex *vert )
|
|||
*/
|
||||
span->interpMask = SPAN_FOG;
|
||||
span->arrayMask = SPAN_XY | SPAN_Z;
|
||||
span->facing = swrast->PointLineFacing;
|
||||
span->attrStart[FRAG_ATTRIB_FOGC][0] = vert->attrib[FRAG_ATTRIB_FOGC][0];
|
||||
span->attrStepX[FRAG_ATTRIB_FOGC][0] = 0.0;
|
||||
span->attrStepY[FRAG_ATTRIB_FOGC][0] = 0.0;
|
||||
|
|
|
|||
|
|
@ -58,7 +58,7 @@ _swrast_culltriangle( GLcontext *ctx,
|
|||
GLfloat fy = v2->win[1] - v0->win[1];
|
||||
GLfloat c = ex*fy-ey*fx;
|
||||
|
||||
if (c * SWRAST_CONTEXT(ctx)->_BackfaceSign > 0)
|
||||
if (c * SWRAST_CONTEXT(ctx)->_BackfaceCullSign > 0)
|
||||
return 0;
|
||||
|
||||
return 1;
|
||||
|
|
|
|||
|
|
@ -172,7 +172,7 @@ static void NAME(GLcontext *ctx, const SWvertex *v0,
|
|||
EdgeT eMaj, eTop, eBot;
|
||||
GLfloat oneOverArea;
|
||||
const SWvertex *vMin, *vMid, *vMax; /* Y(vMin)<=Y(vMid)<=Y(vMax) */
|
||||
GLfloat bf = SWRAST_CONTEXT(ctx)->_BackfaceSign;
|
||||
GLfloat bf = SWRAST_CONTEXT(ctx)->_BackfaceCullSign;
|
||||
#if !TRIANGLE_WALK_DOUBLE
|
||||
const GLint snapMask = ~((FIXED_ONE / (1 << SUB_PIXEL_BITS)) - 1); /* for x/y coord snapping */
|
||||
#endif
|
||||
|
|
@ -293,6 +293,7 @@ static void NAME(GLcontext *ctx, const SWvertex *v0,
|
|||
const GLfloat area = eMaj.dx * eBot.dy - eBot.dx * eMaj.dy;
|
||||
#endif
|
||||
/* Do backface culling */
|
||||
|
||||
if (area * bf < 0.0)
|
||||
return;
|
||||
|
||||
|
|
@ -300,11 +301,11 @@ static void NAME(GLcontext *ctx, const SWvertex *v0,
|
|||
return;
|
||||
|
||||
oneOverArea = 1.0F / area;
|
||||
|
||||
/* 0 = front, 1 = back */
|
||||
span.facing = oneOverArea * swrast->_BackfaceSign > 0.0F;
|
||||
}
|
||||
|
||||
|
||||
span.facing = ctx->_Facing; /* for 2-sided stencil test */
|
||||
|
||||
/* Edge setup. For a triangle strip these could be reused... */
|
||||
{
|
||||
#if TRIANGLE_WALK_DOUBLE
|
||||
|
|
|
|||
|
|
@ -140,6 +140,13 @@ _swrast_Accum(GLcontext *ctx, GLenum op, GLfloat value);
|
|||
extern void
|
||||
_swrast_ResetLineStipple( GLcontext *ctx );
|
||||
|
||||
/**
|
||||
* Indicates front/back facing for subsequent points/lines when drawing
|
||||
* unfilled polygons. Needed for two-side stencil.
|
||||
*/
|
||||
extern void
|
||||
_swrast_SetFacing(GLcontext *ctx, GLuint facing);
|
||||
|
||||
/* These will always render the correct point/line/triangle for the
|
||||
* current state.
|
||||
*
|
||||
|
|
|
|||
|
|
@ -186,6 +186,9 @@ _swsetup_RenderStart( GLcontext *ctx )
|
|||
|
||||
swsetup->NewState = 0;
|
||||
|
||||
/* This will change if drawing unfilled tris */
|
||||
_swrast_SetFacing(ctx, 0);
|
||||
|
||||
_swrast_render_start(ctx);
|
||||
|
||||
/* Important */
|
||||
|
|
|
|||
|
|
@ -1,8 +1,8 @@
|
|||
/*
|
||||
* Mesa 3-D graphics library
|
||||
* Version: 6.1
|
||||
* Version: 7.1
|
||||
*
|
||||
* Copyright (C) 1999-2004 Brian Paul All Rights Reserved.
|
||||
* Copyright (C) 1999-2007 Brian Paul All Rights Reserved.
|
||||
*
|
||||
* Permission is hereby granted, free of charge, to any person obtaining a
|
||||
* copy of this software and associated documentation files (the "Software"),
|
||||
|
|
@ -68,6 +68,8 @@ static void _swsetup_render_line_tri( GLcontext *ctx,
|
|||
return;
|
||||
}
|
||||
|
||||
_swrast_SetFacing(ctx, facing);
|
||||
|
||||
if (ctx->Light.ShadeModel == GL_FLAT) {
|
||||
COPY_CHAN4(c[0], v0->color);
|
||||
COPY_CHAN4(c[1], v1->color);
|
||||
|
|
@ -127,6 +129,8 @@ static void _swsetup_render_point_tri( GLcontext *ctx,
|
|||
return;
|
||||
}
|
||||
|
||||
_swrast_SetFacing(ctx, facing);
|
||||
|
||||
if (ctx->Light.ShadeModel == GL_FLAT) {
|
||||
/* save colors/indexes for v0, v1 vertices */
|
||||
COPY_CHAN4(c[0], v0->color);
|
||||
|
|
@ -311,6 +315,4 @@ void _swsetup_choose_trifuncs( GLcontext *ctx )
|
|||
tnl->Driver.Render.Quad = quad_tab[ind];
|
||||
tnl->Driver.Render.Line = swsetup_line;
|
||||
tnl->Driver.Render.Points = swsetup_points;
|
||||
|
||||
ctx->_Facing = 0;
|
||||
}
|
||||
|
|
|
|||
|
|
@ -43,7 +43,6 @@ static void TAG(triangle)(GLcontext *ctx, GLuint e0, GLuint e1, GLuint e2 )
|
|||
v[1] = &verts[e1];
|
||||
v[2] = &verts[e2];
|
||||
|
||||
|
||||
if (IND & (SS_TWOSIDE_BIT | SS_OFFSET_BIT | SS_UNFILLED_BIT))
|
||||
{
|
||||
GLfloat ex = v[0]->win[0] - v[2]->win[0];
|
||||
|
|
@ -55,7 +54,6 @@ static void TAG(triangle)(GLcontext *ctx, GLuint e0, GLuint e1, GLuint e2 )
|
|||
if (IND & (SS_TWOSIDE_BIT | SS_UNFILLED_BIT))
|
||||
{
|
||||
facing = (cc < 0.0) ^ ctx->Polygon._FrontBit;
|
||||
ctx->_Facing = facing;
|
||||
|
||||
if (IND & SS_UNFILLED_BIT)
|
||||
mode = facing ? ctx->Polygon.BackMode : ctx->Polygon.FrontMode;
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue