fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 13:28:06 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

pps: Open writable renderer node in DrmDevice::create

Browse source 
DrmDevice::create_all correctly opened the node with O_RDWR, while
DrmDevice::create was not, causing failure to create writable buffer.

Fixes pps-config on Freedreno.

Fixes: 1cc72b2aef
("pps: Gfx-pps v0.3.0")

Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Reviewed-by: Antonio Caggiano <antonio.caggiano@collabora.com>
Reviewed-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16406>
(cherry picked from commit 6bf4ae002a)
This commit is contained in:
Danylo Piliaiev 2022-05-09 20:28:28 +03:00 • committed by Dylan Baker
parent 8a560a87b4
commit 1b28c52e44
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -1597,7 +1597,7 @@
"description": "pps: Open writable renderer node in DrmDevice::create",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "1cc72b2aef82373247466c2e7b81970c867ad0fa"
},

2
src/tool/pps/pps_device.cc
View file

@ -101,7 +101,7 @@ std::optional<DrmDevice> DrmDevice::create(int32_t gpu_num)
if (num_devices > 0 && gpu_num < num_devices) {
drmDevicePtr device = devices[gpu_num];
int fd = open(device->nodes[DRM_NODE_RENDER], O_RDONLY);
int fd = open(device->nodes[DRM_NODE_RENDER], O_RDWR);
ret = create_drm_device(fd, gpu_num);
}