panfrost: Hide MSAA 8x/16x support

dEQP-GLES31.functional.texture.multisample.samples_16.sample_position is
failing on Bifrost, and we already weren't advertising on Midgard. Until
someone gets spare cycles to debug all the problems, keep it hidden
behind a debug flag to avoid introducing bugs.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9164>
This commit is contained in:
Alyssa Rosenzweig 2021-02-19 12:44:50 -05:00 committed by Marge Bot
parent 3f21b089f8
commit 1b239a3786
2 changed files with 6 additions and 4 deletions

View file

@ -66,6 +66,7 @@ static const struct debug_named_value panfrost_debug_options[] = {
{"gl3", PAN_DBG_GL3, "Enable experimental GL 3.x implementation, up to 3.3"},
{"noafbc", PAN_DBG_NO_AFBC, "Disable AFBC support"},
{"nocrc", PAN_DBG_NO_CRC, "Disable transaction elimination"},
{"msaa16", PAN_DBG_MSAA16, "Enable MSAA 8x and 16x support"},
DEBUG_NAMED_VALUE_END
};
@ -478,7 +479,7 @@ panfrost_is_format_supported( struct pipe_screen *screen,
return false;
/* MSAA 2x gets rounded up to 4x. MSAA 8x/16x only supported on v5+.
* TODO: Advertise on v5 */
* TODO: debug MSAA 8x/16x */
switch (sample_count) {
case 0:
@ -487,10 +488,10 @@ panfrost_is_format_supported( struct pipe_screen *screen,
break;
case 8:
case 16:
if (dev->arch < 6)
return false;
else
if (dev->debug & PAN_DBG_MSAA16)
break;
else
return false;
default:
return false;
}

View file

@ -39,5 +39,6 @@
#define PAN_DBG_GL3 0x0100
#define PAN_DBG_NO_AFBC 0x0200
#define PAN_DBG_FP16 0x0400
#define PAN_DBG_MSAA16 0x0800
#endif /* PAN_UTIL_H */