fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-25 06:30:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

panfrost: Remove PAN_REQ_DEPTH_WRITE

Browse source 
No consumers, garbage collect the whole thing.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8774>
This commit is contained in:
Alyssa Rosenzweig 2021-01-29 14:43:15 -05:00
parent 37050ad62a
commit 1a6fc40b99
3 changed files with 1 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/gallium/drivers/panfrost/pan_job.c
View file

@ -1216,10 +1216,8 @@ panfrost_batch_set_requirements(struct panfrost_batch *batch)
{
struct panfrost_context *ctx = batch->ctx;
if (ctx->depth_stencil && ctx->depth_stencil->base.depth_writemask) {
batch->requirements |= PAN_REQ_DEPTH_WRITE;
if (ctx->depth_stencil && ctx->depth_stencil->base.depth_writemask)
batch->draws |= PIPE_CLEAR_DEPTH;
}
if (ctx->depth_stencil && ctx->depth_stencil->base.stencil[0].enabled)
batch->draws |= PIPE_CLEAR_STENCIL;

6
src/gallium/drivers/panfrost/pan_job.h
View file

@ -48,8 +48,6 @@ struct panfrost_batch_fence {
struct panfrost_batch *batch;
};
#define PAN_REQ_DEPTH_WRITE (1 << 0)
/* A panfrost_batch corresponds to a bound FBO we're rendering to,
* collecting over multiple draws. */
@ -81,10 +79,6 @@ struct panfrost_batch {
/* Amount of shared memory needed per workgroup (for compute) */
unsigned shared_size;
/* Whether this job uses the corresponding requirement (PAN_REQ_*
* bitmask) */
unsigned requirements;
/* The bounding box covered by this job, taking scissors into account.
* Basically, the bounding box we have to run fragment shaders for */

11
src/gallium/drivers/panfrost/pan_mfbd.c
View file

@ -552,17 +552,6 @@ panfrost_mfbd_fragment(struct panfrost_batch *batch, bool has_draws)
rts = fb + MALI_MULTI_TARGET_FRAMEBUFFER_LENGTH;
}
/* When scanning out, the depth buffer is immediately invalidated, so
* we don't need to waste bandwidth writing it out. This can improve
* performance substantially (Z24X8_UNORM 1080p @ 60fps is 475 MB/s of
* memory bandwidth!).
*
* The exception is ReadPixels, but this is not supported on GLES so we
* can safely ignore it. */
if (panfrost_batch_is_scanout(batch))
batch->requirements &= ~PAN_REQ_DEPTH_WRITE;
struct panfrost_slice *checksum_slice = NULL;
if (zs_crc_ext)