fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-07 04:58:05 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

amd/addrlib: fix forgotten char -> enum conversions

Browse source 
clang warning:
  result of comparison of constant 115 with expression of type
  'const enum Dim' is always false

Fixes: e3e704c7e7 ("amd/addrlib: Use enum instead of sparse chars to identify dimensions")
Reviewed-by: Michel Dänzer <mdaenzer@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5119>
(cherry picked from commit dddd91eef3)
This commit is contained in:
Pierre-Eric Pelloux-Prayer 2020-05-20 15:26:29 +02:00 • committed by Eric Engestrom
parent 511d89f0ad
commit 1a6c365774
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -1453,7 +1453,7 @@
"description": "amd/addrlib: fix forgotten char -> enum conversions",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"master_sha": null,
"because_sha": "e3e704c7e7e46dfda820ea2e96fa4a32d63ef796"
},

4
src/amd/addrlib/src/core/coord.cpp
View file

@ -83,11 +83,11 @@ BOOL_32 Coordinate::operator<(const Coordinate& b)
}
else
{
if (dim == 's' || b.dim == 'm')
if (dim == DIM_S || b.dim == DIM_M)
{
ret = TRUE;
}
else if (b.dim == 's' || dim == 'm')
else if (b.dim == DIM_S || dim == DIM_M)
{
ret = FALSE;
}