fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-06 07:18:17 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

intel/blorp: disable use of REP16 independent of format

Browse source 
Previously we were optimistic and tied this to certain format but wa
description lists other formats and bspec clearly disallows the usage.

Issue can be seen with different 16bpp tests, effect looks a bit like
dithering pattern but it is not, it is just rep16 failing.

Fixes:
   GTF-GL46.gtf42.GL3Tests.texture_storage.texture_storage_texture_as_framebuffer_attachment

on DG2 and MTL, some 565 EGL tests on Android and internal issue on game
that displays a dither like pattern on the background while it's not
supposed to do that.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/10646
Cc: mesa-stable
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27794>
This commit is contained in:
Tapani Pälli 2024-02-26 14:50:17 +02:00 • committed by Marge Bot
parent 1adb2e9e95
commit 1a4f220c29
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/intel/blorp/blorp_clear.c
View file

@ -504,15 +504,17 @@ blorp_clear(struct blorp_batch *batch,
if (batch->blorp->isl_dev->info->ver < 6)
use_simd16_replicated_data = false;
/* From the BSpec: 47719 Replicate Data:
/* From the BSpec: 47719 (TGL/DG2/MTL) Replicate Data:
*
* "Replicate Data Render Target Write message should not be used
* on all projects TGL+."
*
* Xe2 spec (57350) does not mention this restriction.
*
* See 14017879046, 14017880152 for additional information.
*/
if (batch->blorp->isl_dev->info->ver >= 12 &&
format == ISL_FORMAT_R10G10B10_FLOAT_A2_UNORM)
batch->blorp->isl_dev->info->ver < 20)
use_simd16_replicated_data = false;
if (compute)