fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-02-03 10:50:26 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

i965/fs: Remove the inline pack_double_2x32 optimization

Browse source 
It's broken in a number of ways.  In particular, a bunch of the
conditions are backwards so it doesn't actually detect what it's
supposed to detect.  Since it's been broken, it hasn't actually been
helping anything so just deleting it isn't a regression.

This (and removing another optimization) were done on master in commit
b073811617.

Cc: "Kenneth Grunke" <kenneth@whitecape.org>
Cc: "Mark Janes" <mark.a.janes@intel.com>

[Emil Velikov: patch is a backport of the below "cherry pick"]
Fixes: a4393bd97f ("i965/fs: Fix the inline nir_op_pack_double optimization")

(cherry picked from commit b073811617)
This commit is contained in:
Jason Ekstrand 2017-02-14 23:00:51 -08:00 • committed by Emil Velikov
parent ae241b73e6
commit 1966fa2b7f
1 changed files with 0 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
src/mesa/drivers/dri/i965/brw_fs_nir.cpp
View file

@ -1164,35 +1164,6 @@ fs_visitor::nir_emit_alu(const fs_builder &bld, nir_alu_instr *instr)
break;
case nir_op_pack_double_2x32_split:
/* Optimize the common case where we are re-packing a double with
* the result of a previous double unpack. In this case we can take the
* 32-bit value to use in the re-pack from the original double and bypass
* the unpack operation.
*/
for (int i = 0; i < 2; i++) {
if (instr->src[i].src.is_ssa)
continue;
const nir_instr *parent_instr = instr->src[i].src.ssa->parent_instr;
if (parent_instr->type == nir_instr_type_alu)
continue;
const nir_alu_instr *alu_parent = nir_instr_as_alu(parent_instr);
if (alu_parent->op == nir_op_unpack_double_2x32_split_x ||
alu_parent->op == nir_op_unpack_double_2x32_split_y)
continue;
if (!alu_parent->src[0].src.is_ssa)
continue;
op[i] = get_nir_src(alu_parent->src[0].src);
op[i] = offset(retype(op[i], BRW_REGISTER_TYPE_DF), bld,
alu_parent->src[0].swizzle[channel]);
if (alu_parent->op == nir_op_unpack_double_2x32_split_y)
op[i] = subscript(op[i], BRW_REGISTER_TYPE_UD, 1);
else
op[i] = subscript(op[i], BRW_REGISTER_TYPE_UD, 0);
}
bld.emit(FS_OPCODE_PACK, result, op[0], op[1]);
break;