fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-06-11 20:38:32 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

r600/sfn: Don't try to propagate to vec4 with more than one use

Browse source 
Otherwise we end up with weird dependencies that make the scheduler
choke.

Fixes: 18a8d148d8
    r600/sfn: Cleanup copy-prop into vec4 source values

Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24393>
(cherry picked from commit 618fc13db7)
This commit is contained in:
Gert Wollny 2023-07-31 09:36:18 +02:00 • committed by Eric Engestrom
parent 25210fc7b8
commit 17cb76c4d5
2 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -1210,7 +1210,7 @@
"description": "r600/sfn: Don't try to propagate to vec4 with more than one use",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "18a8d148d862d4a0f5b83f4385f00cf8a4a71b6d"
},

4
src/gallium/drivers/r600/sfn/sfn_optimizer.cpp
View file

@ -469,6 +469,9 @@ CopyPropFwdVisitor::propagate_to(RegisterVec4& value, Instr *instr)
if (value[i]->parents().empty())
return;
if (value[i]->uses().size() > 1)
return;
assert(value[i]->parents().size() == 1);
parents[i] = (*value[i]->parents().begin())->as_alu();
@ -477,6 +480,7 @@ CopyPropFwdVisitor::propagate_to(RegisterVec4& value, Instr *instr)
if (!parents[i])
return;
if ((parents[i]->opcode() != op1_mov) ||
parents[i]->has_alu_flag(alu_src0_neg) ||
parents[i]->has_alu_flag(alu_src0_abs) ||