fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-03 15:50:17 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

pan/bi: Avoid masked writes for now

Browse source 
Our swizzle lowering optimizations depend on replication of scalar fp16. This
holds on Bifrost (at least for now), but not on Valhall which has proper support
for write masks. For now, enforce Bifrost-compatible behaviour as we do not make
use of the write masks on Valhall yet.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15793>
This commit is contained in:
Alyssa Rosenzweig 2022-03-23 12:21:12 -04:00 • committed by Marge Bot
parent ba5b63f642
commit 170d5a012e
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/panfrost/bifrost/bi_lower_swizzle.c
View file

@ -259,6 +259,12 @@ bi_lower_swizzle(bi_context *ctx)
ins->op = BI_OPCODE_MOV_I32;
ins->src[0].swizzle = BI_SWIZZLE_H01;
}
/* The above passes rely on replicating destinations. For
* Valhall, we will want to optimize this. For now, default
* to Bifrost compatible behaviour.
*/
ins->dest[0].swizzle = BI_SWIZZLE_H01;
}
free(replicates_16);