fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-05 07:28:11 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

anv: Fix transfer type assert

Browse source 
Fix defect reported by Coverity Scan.

Constant expression result (CONSTANT_EXPRESSION_RESULT)
always_true_or: The or condition
type != ANV_TIMESTAMP_CAPTURE_AT_CS_STALL || type != ANV_TIMESTAMP_REWRITE_COMPUTE_WALKER
will always be true because type cannot be equal to two different values
at the same time, so it must be not equal to at least one of them.

Fixes: 5112b42146 ("anv: Handle end of pipe with MI_FLUSH_DW on transfer queue")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25605>
This commit is contained in:
Vinson Lee 2023-10-08 10:09:59 -07:00
parent 1e820ac128
commit 16fa4621b8
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/intel/vulkan/genX_cmd_buffer.c
View file

@ -8158,7 +8158,7 @@ void genX(cmd_emit_timestamp)(struct anv_batch *batch,
* transfer queue.
*/
if (batch->engine_class == INTEL_ENGINE_CLASS_COPY) {
assert(type != ANV_TIMESTAMP_CAPTURE_AT_CS_STALL ||
assert(type != ANV_TIMESTAMP_CAPTURE_AT_CS_STALL &&
type != ANV_TIMESTAMP_REWRITE_COMPUTE_WALKER);
}