fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-29 18:50:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

panfrost/midgard: Simplify blend read

Browse source 
It's not clear where the extra indirection was from (older hardware or
just older blobs?)

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
This commit is contained in:
Alyssa Rosenzweig 2019-07-01 17:23:58 -07:00
parent 952993d3bb
commit 1686ef8655
1 changed files with 5 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
src/gallium/drivers/panfrost/midgard/midgard_compile.c
View file

@ -1236,27 +1236,6 @@ emit_sysval_read(compiler_context *ctx, nir_instr *instr)
emit_ubo_read(ctx, dest, uniform, NULL, 0);
}
/* Reads RGBA8888 value from the tilebuffer and converts to a RGBA32F register,
* using scalar ops functional on earlier Midgard generations. Newer Midgard
* generations have faster vectorized reads. This operation is for blend
* shaders in particular; reading the tilebuffer from the fragment shader
* remains an open problem. */
static void
emit_fb_read_blend_scalar(compiler_context *ctx, unsigned reg)
{
midgard_instruction ins = m_ld_color_buffer_8(reg, 0);
ins.load_store.swizzle = 0; /* xxxx */
/* Read each component sequentially */
for (unsigned c = 0; c < 4; ++c) {
ins.load_store.mask = (1 << c);
ins.load_store.unknown = c;
emit_mir_instruction(ctx, ins);
}
}
static void
emit_intrinsic(compiler_context *ctx, nir_intrinsic_instr *instr)
{
@ -1367,11 +1346,14 @@ emit_intrinsic(compiler_context *ctx, nir_intrinsic_instr *instr)
break;
}
/* Reads off the tilebuffer during blending, tasty */
/* Reads 128-bit value raw off the tilebuffer during blending, tasty */
case nir_intrinsic_load_raw_output_pan:
reg = nir_dest_index(ctx, &instr->dest);
assert(ctx->is_blend);
emit_fb_read_blend_scalar(ctx, reg);
midgard_instruction ins = m_ld_color_buffer_8(reg, 0);
emit_mir_instruction(ctx, ins);
break;
case nir_intrinsic_load_blend_const_color_rgba: {