From 1579ff453e2bc1494c33f4cb71bde543e2fdf750 Mon Sep 17 00:00:00 2001 From: Iago Toral Quiroga Date: Tue, 4 Feb 2025 08:16:51 +0100 Subject: [PATCH] v3dv: fix missing access bit flag when checking for texel buffer reads VK_ACCESS_2_SHADER_READ_BIT matches all types of reads from shaders, texel buffers too. Reviewed-by: Juan A. Suarez cc: mesa-stable Part-of: (cherry picked from commit a6dc8fa426ef104ed3635e18832b9998a0499f82) --- .pick_status.json | 2 +- src/broadcom/vulkan/v3dv_cmd_buffer.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.pick_status.json b/.pick_status.json index d4455ddb1f4..a71707d1427 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -534,7 +534,7 @@ "description": "v3dv: fix missing access bit flag when checking for texel buffer reads", "nominated": true, "nomination_type": 1, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": null, "notes": null diff --git a/src/broadcom/vulkan/v3dv_cmd_buffer.c b/src/broadcom/vulkan/v3dv_cmd_buffer.c index 33bed9065ad..8672f71a0bd 100644 --- a/src/broadcom/vulkan/v3dv_cmd_buffer.c +++ b/src/broadcom/vulkan/v3dv_cmd_buffer.c @@ -2844,6 +2844,7 @@ cmd_buffer_binning_sync_required(struct v3dv_cmd_buffer *cmd_buffer, /* Texel Buffer read */ if (buffer_access & (VK_ACCESS_2_SHADER_SAMPLED_READ_BIT | + VK_ACCESS_2_SHADER_READ_BIT | VK_ACCESS_2_MEMORY_READ_BIT)) { if (vs_bin_maps->texture_map.num_desc > 0) return true;