From 13dcbdcdf341ec269e4d2c53ceb5a1007169fb01 Mon Sep 17 00:00:00 2001 From: Samuel Pitoiset Date: Thu, 30 Nov 2023 17:53:19 +0100 Subject: [PATCH] radv: make sure to reset the stipple line state when it's disabled In a scenario like: CmdBindPipeline(stipple line enabled) CmdDraw() CmdBindPipeline(stipple line disabled) CmdDraw() The second draw wasn't resetting the stipple line state and this might have caused issues, though it's uncovered by VK CTS. Signed-off-by: Samuel Pitoiset Part-of: --- src/amd/vulkan/radv_pipeline_graphics.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline_graphics.c b/src/amd/vulkan/radv_pipeline_graphics.c index d63792e8ad9..bbc94d9d3d7 100644 --- a/src/amd/vulkan/radv_pipeline_graphics.c +++ b/src/amd/vulkan/radv_pipeline_graphics.c @@ -557,9 +557,6 @@ radv_pipeline_needed_dynamic_state(const struct radv_device *device, const struc (!state->ms || !state->ms->sample_locations_enable)) states &= ~RADV_DYNAMIC_SAMPLE_LOCATIONS; - if (!(pipeline->dynamic_states & RADV_DYNAMIC_LINE_STIPPLE_ENABLE) && !state->rs->line.stipple.enable) - states &= ~RADV_DYNAMIC_LINE_STIPPLE; - if (!has_color_att || !radv_pipeline_is_blend_enabled(pipeline, state->cb)) states &= ~RADV_DYNAMIC_BLEND_CONSTANTS;