fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-24 00:10:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

radv: Check for shareable images in central place.

Browse source 
One place to put the logic makes things easier to change.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
This commit is contained in:
Bas Nieuwenhuizen 2018-11-26 16:26:37 +01:00 • committed by Bas Nieuwenhuizen
parent 3bf48741e1
commit 12e35a64c0
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/amd/vulkan/radv_image.c
View file

@ -122,13 +122,12 @@ radv_use_tc_compat_htile_for_image(struct radv_device *device,
static bool static bool
radv_use_dcc_for_image(struct radv_device *device, radv_use_dcc_for_image(struct radv_device *device,
const struct radv_image *image,
const struct radv_image_create_info *create_info, const struct radv_image_create_info *create_info,
const VkImageCreateInfo *pCreateInfo) const VkImageCreateInfo *pCreateInfo)
{ {
bool dcc_compatible_formats; bool dcc_compatible_formats;
bool blendable; bool blendable;
bool shareable = vk_find_struct_const(pCreateInfo->pNext,
EXTERNAL_MEMORY_IMAGE_CREATE_INFO_KHR) != NULL;
/* DCC (Delta Color Compression) is only available for GFX8+. */ /* DCC (Delta Color Compression) is only available for GFX8+. */
if (device->physical_device->rad_info.chip_class < VI) if (device->physical_device->rad_info.chip_class < VI)
@ -139,7 +138,7 @@ radv_use_dcc_for_image(struct radv_device *device,
/* FIXME: DCC is broken for shareable images starting with GFX9 */ /* FIXME: DCC is broken for shareable images starting with GFX9 */
if (device->physical_device->rad_info.chip_class >= GFX9 && if (device->physical_device->rad_info.chip_class >= GFX9 &&
shareable) image->shareable)
return false; return false;
/* TODO: Enable DCC for storage images. */ /* TODO: Enable DCC for storage images. */
@ -198,6 +197,7 @@ radv_use_dcc_for_image(struct radv_device *device,
static int static int
radv_init_surface(struct radv_device *device, radv_init_surface(struct radv_device *device,
const struct radv_image *image,
struct radeon_surf *surface, struct radeon_surf *surface,
const struct radv_image_create_info *create_info) const struct radv_image_create_info *create_info)
{ {
@ -251,7 +251,7 @@ radv_init_surface(struct radv_device *device,
surface->flags |= RADEON_SURF_OPTIMIZE_FOR_SPACE; surface->flags |= RADEON_SURF_OPTIMIZE_FOR_SPACE;
if (!radv_use_dcc_for_image(device, create_info, pCreateInfo)) if (!radv_use_dcc_for_image(device, image, create_info, pCreateInfo))
surface->flags |= RADEON_SURF_DISABLE_DCC; surface->flags |= RADEON_SURF_DISABLE_DCC;
if (create_info->scanout) if (create_info->scanout)
@ -981,7 +981,7 @@ radv_image_create(VkDevice _device,
image->info.surf_index = &device->image_mrt_offset_counter; image->info.surf_index = &device->image_mrt_offset_counter;
} }
radv_init_surface(device, &image->surface, create_info); radv_init_surface(device, image, &image->surface, create_info);
device->ws->surface_init(device->ws, &image->info, &image->surface); device->ws->surface_init(device->ws, &image->info, &image->surface);