fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-05 13:58:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

glsl/glcpp: Add test for a multi-line comment within an #if 0 block

Browse source 
This test is written to exercise a bug which I recently wrote, (but
fortunately caught and fixed before ever committing it).

For the curious:

  The bug happened when the NEWLINE_CATCHUP code didn't actually return the
  NEWLINE token (due to the skipping). This resulted in the lexer continuing
  on through all the subsequent rules while still in the NEWLINE_CATCHUP start
  condition, (which then triggered the internal-compiler-error catch-all
  rule).

  What is intended is for the return of the NEWLINE token to start a new
  iteration of the lexer loop, at which time the NEWLINE_CATCHUP-handling code
  will reset from the <NEWLINE_CATCHUP> to the <INITIAL> start condition.

Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
This commit is contained in:
Carl Worth 2014-06-26 10:56:41 -07:00
parent 346d712e87
commit 12d583b21a
2 changed files with 14 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/glsl/glcpp/tests/138-multi-line-comment-in-if-0.c Normal file
View file

@ -0,0 +1,7 @@
#if 0
/*
* This multi-line comment needs to be 3 lines to test what's intended.
*/
#else
SUCCESS
#endif

7
src/glsl/glcpp/tests/138-multi-line-comment-in-if-0.c.expected Normal file
View file

@ -0,0 +1,7 @@
SUCCESS