diff --git a/.pick_status.json b/.pick_status.json index 59430d40b17..a52d56e7acf 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -954,7 +954,7 @@ "description": "radv/video: Correctly handle no feedback query for encode", "nominated": true, "nomination_type": 1, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": null, "notes": null diff --git a/src/amd/vulkan/radv_video_enc.c b/src/amd/vulkan/radv_video_enc.c index ef8a9f117ac..8467bd683b9 100644 --- a/src/amd/vulkan/radv_video_enc.c +++ b/src/amd/vulkan/radv_video_enc.c @@ -2765,7 +2765,7 @@ radv_vcn_encode_video(struct radv_cmd_buffer *cmd_buffer, const VkVideoEncodeInf cmd_buffer->video.enc.total_task_size = 0; // task info - radv_enc_task_info(cmd_buffer, true); + radv_enc_task_info(cmd_buffer, feedback_query_va); if (vid->enc_need_begin) { begin(cmd_buffer, enc_info); @@ -2834,7 +2834,7 @@ radv_vcn_encode_video(struct radv_cmd_buffer *cmd_buffer, const VkVideoEncodeInf if (pdev->enc_hw_ver >= RADV_VIDEO_ENC_HW_2) { radv_vcn_sq_tail(cs, &cmd_buffer->video.sq); - if (radv_video_write_memory_supported(pdev) == RADV_VIDEO_WRITE_MEMORY_SUPPORT_FULL) + if (feedback_query_va && radv_video_write_memory_supported(pdev) == RADV_VIDEO_WRITE_MEMORY_SUPPORT_FULL) radv_vcn_write_memory(cmd_buffer, feedback_query_va + RADV_ENC_FEEDBACK_STATUS_IDX * sizeof(uint32_t), 1); } }