From 112f3892615ab363adad4ad17ad8716286aae478 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Sch=C3=BCrmann?= Date: Mon, 8 Feb 2021 17:30:26 +0100 Subject: [PATCH] aco: don't abort() if disassembly fails We used that to catch assembly errors in the past, but now, there are too many hardware features we use in ACO that are not supported by the LLVM disassembler, that it is not really suited anymore as a debugging tool. Reviewed-by: Rhys Perry Part-of: --- src/amd/compiler/aco_interface.cpp | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/amd/compiler/aco_interface.cpp b/src/amd/compiler/aco_interface.cpp index 1518615e7f5..358a6b88022 100644 --- a/src/amd/compiler/aco_interface.cpp +++ b/src/amd/compiler/aco_interface.cpp @@ -184,16 +184,9 @@ void aco_compile_shader(unsigned shader_count, struct u_memstream mem; if (u_memstream_open(&mem, &data, &disasm_size)) { FILE *const memf = u_memstream_get(&mem); - bool fail = aco::print_asm(program.get(), code, exec_size / 4u, memf); + aco::print_asm(program.get(), code, exec_size / 4u, memf); fputc(0, memf); u_memstream_close(&mem); - - if (fail) { - fprintf(stderr, "Failed to disassemble program:\n"); - aco_print_program(program.get(), stderr); - fputs(data, stderr); - abort(); - } } disasm = std::string(data, data + disasm_size);