From 10f259e673eb1436eb958084bcda21747dbd7e58 Mon Sep 17 00:00:00 2001 From: Steev Klimaszewski Date: Sat, 13 Dec 2025 18:19:15 -0600 Subject: [PATCH] tu: Stop printing descriptor pool allocation failures The VK_ERROR_FRAGMENTED_POOL and VK_ERROR_OUT_OF_POOL_MEMORY errors are not as exceptional cases as most. These are expected to be hit by applications in the normal course of doing their thing. Probably best not to spam stderr and the debug logs with them. Part-of: --- src/freedreno/vulkan/tu_descriptor_set.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/freedreno/vulkan/tu_descriptor_set.cc b/src/freedreno/vulkan/tu_descriptor_set.cc index 2a211358f6e..1a00b886060 100644 --- a/src/freedreno/vulkan/tu_descriptor_set.cc +++ b/src/freedreno/vulkan/tu_descriptor_set.cc @@ -574,7 +574,7 @@ tu_descriptor_set_create(struct tu_device *device, if (pool->host_memory_base) { if (pool->host_memory_end - pool->host_memory_ptr < mem_size) - return vk_error(device, VK_ERROR_OUT_OF_POOL_MEMORY); + return VK_ERROR_OUT_OF_POOL_MEMORY; set = (struct tu_descriptor_set*)pool->host_memory_ptr; pool->host_memory_ptr += mem_size; @@ -614,7 +614,7 @@ tu_descriptor_set_create(struct tu_device *device, if (!pool->host_memory_base && pool->entry_count == pool->max_entry_count) { vk_object_free(&device->vk, NULL, set); - return vk_error(device, VK_ERROR_OUT_OF_POOL_MEMORY); + return VK_ERROR_OUT_OF_POOL_MEMORY; } uint64_t current_offset = pool->current_offset; @@ -623,7 +623,7 @@ tu_descriptor_set_create(struct tu_device *device, uint64_t pool_vma_offset = util_vma_heap_alloc(&pool->bo_heap, set->size, 1); if (!pool_vma_offset) - return vk_error(device, VK_ERROR_FRAGMENTED_POOL); + return VK_ERROR_FRAGMENTED_POOL; assert(pool_vma_offset >= TU_POOL_HEAP_OFFSET && pool_vma_offset <= pool->size + TU_POOL_HEAP_OFFSET); @@ -631,7 +631,7 @@ tu_descriptor_set_create(struct tu_device *device, current_offset = set->offset; } else { if (current_offset + set->size > pool->size) - return vk_error(device, VK_ERROR_OUT_OF_POOL_MEMORY); + return VK_ERROR_OUT_OF_POOL_MEMORY; pool->current_offset += set->size; }