fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-24 04:08:10 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

pan/afbc: Code motion for split modifier queries

Browse source 
Reorder the AFBC modifier checking code to first query whether the
device can do the mode at all, then to query whether or not the format +
modifier is supported at all, then to query whether the specific image
usage is OK, then to query whether or not it's optimal.

This will come in useful later when we want to split modifier queries
into: can this modifier ever be used, what can this modifier be used
for, and is this the best modifier for this usage.

Signed-off-by: Daniel Stone <daniels@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/40886>
This commit is contained in:
Daniel Stone 2026-05-14 14:18:37 +01:00 • committed by Marge Bot
parent 48ec237bf9
commit 0fb529053b
1 changed files with 21 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

45
src/panfrost/lib/pan_mod.c
View file

@ -182,30 +182,36 @@ pan_mod_afbc_test_props(const struct pan_kmod_dev_props *dprops,
const struct pan_image_props *iprops,
const struct pan_image_usage *iusage)
{
/* No image store. */
if (iusage && iusage->bind & PAN_BIND_STORAGE_IMAGE)
return PAN_MOD_NOT_SUPPORTED;
/* We don't implement mapping individual tiles with AFBC. */
if (iusage && iusage->standard_sparse_mapping_granularity)
return PAN_MOD_NOT_SUPPORTED;
/* AFBC not supported. */
if (!pan_query_afbc(dprops))
return PAN_MOD_NOT_SUPPORTED;
/* Not all architectures support tiled mode */
if ((iprops->modifier & AFBC_FORMAT_MOD_TILED) && !pan_afbc_can_tile(PAN_ARCH))
return PAN_MOD_NOT_SUPPORTED;
unsigned plane_count = util_format_get_num_planes(iprops->format);
const struct util_format_description *fdesc =
util_format_description(iprops->format);
/* Check if the format is supported first. */
/* Check if the format supports AFBC */
enum pan_afbc_mode plane_modes[3];
for (unsigned p = 0; p < plane_count; p++) {
plane_modes[p] = pan_afbc_format(PAN_ARCH, iprops->format, p);
if (plane_modes[p] == PAN_AFBC_MODE_INVALID)
return PAN_MOD_NOT_SUPPORTED;
if ((iprops->modifier & AFBC_FORMAT_MOD_SPLIT) &&
!pan_afbc_can_split(PAN_ARCH, plane_modes[p], iprops->modifier)) {
return PAN_MOD_NOT_SUPPORTED;
}
}
/* YTR is only useful on RGB formats. */
if ((iprops->modifier & AFBC_FORMAT_MOD_YTR) &&
(pan_format_is_yuv(iprops->format) || fdesc->nr_channels < 3))
return PAN_MOD_NOT_SUPPORTED;
/* AFBC can't do multisampling. */
if (iprops->nr_samples > 1)
return PAN_MOD_NOT_SUPPORTED;
@ -215,32 +221,23 @@ pan_mod_afbc_test_props(const struct pan_kmod_dev_props *dprops,
iprops->dim != MALI_TEXTURE_DIMENSION_2D)
return PAN_MOD_NOT_SUPPORTED;
/* No image store. */
if (iusage && iusage->bind & PAN_BIND_STORAGE_IMAGE)
return PAN_MOD_NOT_SUPPORTED;
/* ZS buffer descriptors can't pass split/wide/YTR modifiers. */
if (iusage && (iusage->bind & PAN_BIND_DEPTH_STENCIL) &&
(pan_afbc_superblock_width(iprops->modifier) != 16 ||
(iprops->modifier & (AFBC_FORMAT_MOD_SPLIT | AFBC_FORMAT_MOD_YTR))))
return PAN_MOD_NOT_SUPPORTED;
/* YTR is only useful on RGB formats. */
if ((iprops->modifier & AFBC_FORMAT_MOD_YTR) &&
(pan_format_is_yuv(iprops->format) || fdesc->nr_channels < 3))
/* We don't implement mapping individual tiles with AFBC. */
if (iusage && iusage->standard_sparse_mapping_granularity)
return PAN_MOD_NOT_SUPPORTED;
/* Make sure all planes support split mode. */
if ((iprops->modifier & AFBC_FORMAT_MOD_SPLIT)) {
for (unsigned p = 0; p < plane_count; p++) {
if (!pan_afbc_can_split(PAN_ARCH, plane_modes[p], iprops->modifier))
return PAN_MOD_NOT_SUPPORTED;
}
}
struct pan_image_block_size superblock_extent_px = pan_afbc_superblock_size(iprops->modifier);
if (iprops->modifier & AFBC_FORMAT_MOD_TILED) {
/* Make sure tiled mode is supported. */
if (!pan_afbc_can_tile(PAN_ARCH))
return PAN_MOD_NOT_SUPPORTED;
struct pan_image_block_size tile_extent_px = {
superblock_extent_px.width * pan_afbc_tile_size(iprops->format, iprops->modifier),
superblock_extent_px.height * pan_afbc_tile_size(iprops->format, iprops->modifier),