fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-06 09:28:07 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

pan/midgard: Check for null consts

Browse source 
Valid shaders shouldn't hit this, but Coverity doesn't know that.

CID 1458029:    (FORWARD_NULL)
Passing null pointer "consts" to "print_scalar_field", which dereferences it.

Tomeu: Fix name of variable

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3684>
This commit is contained in:
Alyssa Rosenzweig 2020-02-03 14:32:22 -05:00 • committed by Tomeu Vizoso
parent 8ec4028d40
commit 0f3eb7989b
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/panfrost/midgard/disassemble.c
View file

@ -337,6 +337,8 @@ print_scalar_constant(FILE *fp, unsigned src_binary,
midgard_scalar_alu_src *src = (midgard_scalar_alu_src *)&src_binary;
unsigned mod = 0;
assert(consts != NULL);
if (!midgard_is_integer_op(alu->op)) {
if (src->abs)
mod |= MIDGARD_FLOAT_MOD_ABS;