fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-22 22:10:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

freedreno: simplify fd_set_shader_buffers(..)

Browse source 
Clear the modified bits for enabled_mask and then iterate over the
whole range and set the specific bit where there is a buffer.

Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Reviewed-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1963>
This commit is contained in:
Christian Gmeiner 2019-09-13 08:20:46 +02:00 • committed by Marge Bot
parent 3340cbd398
commit 0ed053f03d
1 changed files with 8 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
src/gallium/drivers/freedreno/freedreno_state.c
View file

@ -128,11 +128,13 @@ fd_set_shader_buffers(struct pipe_context *pctx,
struct fd_shaderbuf_stateobj *so = &ctx->shaderbuf[shader]; struct fd_shaderbuf_stateobj *so = &ctx->shaderbuf[shader];
const unsigned modified_bits = u_bit_consecutive(start, count); const unsigned modified_bits = u_bit_consecutive(start, count);
if (buffers) { so->enabled_mask &= ~modified_bits;
for (unsigned i = 0; i < count; i++) {
unsigned n = i + start;
struct pipe_shader_buffer *buf = &so->sb[n];
for (unsigned i = 0; i < count; i++) {
unsigned n = i + start;
struct pipe_shader_buffer *buf = &so->sb[n];
if (buffers && buffers[i].buffer) {
if ((buf->buffer == buffers[i].buffer) && if ((buf->buffer == buffers[i].buffer) &&
(buf->buffer_offset == buffers[i].buffer_offset) && (buf->buffer_offset == buffers[i].buffer_offset) &&
(buf->buffer_size == buffers[i].buffer_size)) (buf->buffer_size == buffers[i].buffer_size))
@ -142,20 +144,10 @@ fd_set_shader_buffers(struct pipe_context *pctx,
buf->buffer_size = buffers[i].buffer_size; buf->buffer_size = buffers[i].buffer_size;
pipe_resource_reference(&buf->buffer, buffers[i].buffer); pipe_resource_reference(&buf->buffer, buffers[i].buffer);
if (buf->buffer) so->enabled_mask |= BIT(n);
so->enabled_mask |= BIT(n); } else {
else
so->enabled_mask &= ~BIT(n);
}
} else {
for (unsigned i = 0; i < count; i++) {
unsigned n = i + start;
struct pipe_shader_buffer *buf = &so->sb[n];
pipe_resource_reference(&buf->buffer, NULL); pipe_resource_reference(&buf->buffer, NULL);
} }
so->enabled_mask &= ~modified_bits;
} }
ctx->dirty_shader[shader] |= FD_DIRTY_SHADER_SSBO; ctx->dirty_shader[shader] |= FD_DIRTY_SHADER_SSBO;