fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 09:08:10 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

panfrost: Properly name CSF instruction UMIN32 source 0

Browse source 
Was named source 2, but it's actually source 0.

Signed-off-by: Mary Guillemard <mary.guillemard@collabora.com>
Reviewed-by: Lars-Ivar Hesselberg Simonsen <lars-ivar.simonsen@arm.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33371>
This commit is contained in:
Mary Guillemard 2025-01-30 11:56:12 +00:00 • committed by Marge Bot
parent 7bb6ebe938
commit 0e7ac7d65f
3 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/panfrost/lib/genxml/cs_builder.h
View file

@ -1258,7 +1258,7 @@ cs_umin32(struct cs_builder *b, struct cs_index dest, struct cs_index src1,
cs_emit(b, UMIN32, I) {
I.destination = cs_dst32(b, dest);
I.source_1 = cs_src32(b, src1);
I.source_2 = cs_src32(b, src2);
I.source_0 = cs_src32(b, src2);
}
}

6
src/panfrost/lib/genxml/decode_csf.c
View file

@ -223,7 +223,7 @@ print_cs_instr(FILE *fp, const uint64_t *instr)
cs_unpack(instr, CS_UMIN32, I);
fprintf(fp, "UMIN32 r%u, r%u, r%u", I.destination, I.source_1,
I.source_2);
I.source_0);
break;
}
@ -1195,7 +1195,7 @@ record_indirect_branch_target(struct cs_code_cfg *cfg,
case MALI_CS_OPCODE_UMIN32: {
cs_unpack(instr, CS_UMIN32, I);
reg_file.u32[I.destination] =
MIN2(reg_file.u32[I.source_1], reg_file.u32[I.source_2]);
MIN2(reg_file.u32[I.source_1], reg_file.u32[I.source_0]);
break;
}
@ -1273,7 +1273,7 @@ collect_indirect_branch_targets_recurse(struct cs_code_cfg *cfg,
cs_unpack(instr, CS_UMIN32, I);
if (BITSET_TEST(track_map, I.destination)) {
BITSET_SET(track_map, I.source_1);
BITSET_SET(track_map, I.source_2);
BITSET_SET(track_map, I.source_0);
BITSET_CLEAR(track_map, I.destination);
}
break;

2
src/panfrost/lib/genxml/v10.xml
View file

@ -643,7 +643,7 @@
<struct name="CS UMIN32" size="2">
<field name="Source 1" size="8" start="32" type="uint"/>
<field name="Source 2" size="8" start="40" type="uint"/>
<field name="Source 0" size="8" start="40" type="uint"/>
<field name="Destination" size="8" start="48" type="uint"/>
<field name="Opcode" size="8" start="56" type="CS Opcode" default="UMIN32"/>
</struct>