From 0b24fd174a8cf9543b07bdfa150d868d673ce44a Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Wed, 29 Oct 2025 09:59:13 -0400 Subject: [PATCH] zink: collapse gfx pipeline fetching and binding conditionals this avoids taking the wrong conditional if a pipeline fetch fails cc: mesa-stable Part-of: --- src/gallium/drivers/zink/zink_draw.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/zink/zink_draw.cpp b/src/gallium/drivers/zink/zink_draw.cpp index fcafbe02edc..83e705c9f70 100644 --- a/src/gallium/drivers/zink/zink_draw.cpp +++ b/src/gallium/drivers/zink/zink_draw.cpp @@ -270,8 +270,7 @@ update_gfx_pipeline(struct zink_context *ctx, struct zink_batch_state *bs, enum pipeline = zink_get_gfx_pipeline(ctx, ctx->curr_program, &ctx->gfx_pipeline_state, mode); else pipeline = zink_get_gfx_pipeline(ctx, ctx->curr_program, &ctx->gfx_pipeline_state, mode); - } - if (pipeline) { + assert(pipeline); pipeline_changed = prev_pipeline != pipeline || ctx->shobj_draw; if (BATCH_CHANGED || pipeline_changed) VKCTX(CmdBindPipeline)(bs->cmdbuf, VK_PIPELINE_BIND_POINT_GRAPHICS, pipeline);