fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-09 08:58:02 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

intel/fs: Add missing synchronization for WaW dependency

Browse source 
v2: Do the synchronization in the correct place.  Noticed by Curro.

Fixes: b5fa43952a ("intel/fs: Better handle constant sources of FS_OPCODE_PACK_HALF_2x16_SPLIT")
Reviewed-by: Francisco Jerez <currojerez@riseup.net>
Tested-by: Felix DeGrood <felix.j.degrood@intel.com> [v1]
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17037>
(cherry picked from commit 676acfe956)
This commit is contained in:
Ian Romanick 2022-06-14 12:30:21 -07:00 • committed by Dylan Baker
parent ff1ffa4f03
commit 0acb0f4a63
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -1651,7 +1651,7 @@
"description": "intel/fs: Add missing synchronization for WaW dependency",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "b5fa43952aaf7a41385402ad2d21af5a17805615"
},

2
src/intel/compiler/brw_fs_generator.cpp
View file

@ -1785,7 +1785,9 @@ fs_generator::generate_pack_half_2x16_split(fs_inst *,
if (y.file == IMM) {
const uint32_t hhhh0000 = _mesa_float_to_half(y.f) << 16;
brw_MOV(p, dst, brw_imm_ud(hhhh0000));
brw_set_default_swsb(p, tgl_swsb_regdist(1));
} else {
/* Give each 32-bit channel of dst the form below, where "." means
* unchanged.