fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 11:18:08 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

util: Optimize mesa_hex_to_bytes

Browse source 
This function ends up getting called an awful lot when loading a large
Fossilize cache db, so let's replace strtol with something more
reasonable.

For a game with 97k shaders, this reduces instance creation time from
203ms to 52ms.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27052>
This commit is contained in:
Tatsuyuki Ishi 2024-01-14 01:25:17 +09:00 • committed by Marge Bot
parent 34e72579cd
commit 0a68a94a51
1 changed files with 13 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
src/util/hex.h
View file

@ -23,8 +23,6 @@
#ifndef UTIL_HEX_H
#define UTIL_HEX_H
#include <stdlib.h>
#ifdef __cplusplus
extern "C" {
#endif
@ -47,18 +45,24 @@ static inline char *mesa_bytes_to_hex(char *buf, const unsigned char *binary,
return buf;
}
static inline int _mesa_hex_to_int(unsigned char c)
{
return c - (c >= 'a' ? 'a' - 10 : '0');
}
/*
* Read `len` pairs of hexadecimal digits from `hex` and write the values to
* `binary` as `len` bytes.
* Hexadecimals must be lower case.
*/
static inline void mesa_hex_to_bytes(unsigned char *buf, const char *hex,
unsigned len) {
unsigned len)
{
for (unsigned i = 0; i < len; i++) {
char tmp[3];
tmp[0] = hex[i * 2];
tmp[1] = hex[(i * 2) + 1];
tmp[2] = '\0';
buf[i] = strtol(tmp, NULL, 16);
int hi = _mesa_hex_to_int(hex[i * 2]);
int lo = _mesa_hex_to_int(hex[i * 2 + 1]);
buf[i] = (hi << 4) | lo;
}
}
@ -66,4 +70,4 @@ static inline void mesa_hex_to_bytes(unsigned char *buf, const char *hex,
}
#endif
#endif
#endif