diff --git a/.pick_status.json b/.pick_status.json index 2cf9b5f8788..40dc0127ed9 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -85,7 +85,7 @@ "description": "amd: fix buggy usage of unreachable()", "nominated": true, "nomination_type": 0, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": null }, diff --git a/src/amd/llvm/ac_llvm_build.c b/src/amd/llvm/ac_llvm_build.c index dde69a0aa4a..5bdf97a03aa 100644 --- a/src/amd/llvm/ac_llvm_build.c +++ b/src/amd/llvm/ac_llvm_build.c @@ -1693,7 +1693,7 @@ LLVMValueRef ac_build_umsb(struct ac_llvm_context *ctx, LLVMValueRef arg, LLVMTy zero = ctx->i8_0; break; default: - unreachable(!"invalid bitsize"); + unreachable("invalid bitsize"); break; } @@ -2483,7 +2483,7 @@ LLVMValueRef ac_build_bit_count(struct ac_llvm_context *ctx, LLVMValueRef src0) result = LLVMBuildZExt(ctx->builder, result, ctx->i32, ""); break; default: - unreachable(!"invalid bitsize"); + unreachable("invalid bitsize"); break; } @@ -2514,7 +2514,7 @@ LLVMValueRef ac_build_bitfield_reverse(struct ac_llvm_context *ctx, LLVMValueRef result = LLVMBuildZExt(ctx->builder, result, ctx->i32, ""); break; default: - unreachable(!"invalid bitsize"); + unreachable("invalid bitsize"); break; } @@ -2595,7 +2595,7 @@ LLVMValueRef ac_find_lsb(struct ac_llvm_context *ctx, LLVMTypeRef dst_type, LLVM zero = ctx->i8_0; break; default: - unreachable(!"invalid bitsize"); + unreachable("invalid bitsize"); } LLVMValueRef params[2] = { diff --git a/src/gallium/drivers/r600/sfn/sfn_nir_lower_64bit.cpp b/src/gallium/drivers/r600/sfn/sfn_nir_lower_64bit.cpp index 7beadd966e4..ad2144dcdd4 100644 --- a/src/gallium/drivers/r600/sfn/sfn_nir_lower_64bit.cpp +++ b/src/gallium/drivers/r600/sfn/sfn_nir_lower_64bit.cpp @@ -383,7 +383,7 @@ LowerSplit64BitVar::split_double_load_deref(nir_intrinsic_instr *intr) else if (deref->deref_type == nir_deref_type_array) return split_load_deref_array(intr, deref->arr.index); else { - unreachable(0 && "only splitting of loads from vars and arrays is supported"); + unreachable("only splitting of loads from vars and arrays is supported"); } m_old_stores.push_back(&intr->instr); }