fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-06-21 05:58:22 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

jay: allow more 3-src imms

Browse source 
SIMD16:
   Totals from 2082 (78.66% of 2647) affected shaders:
   Instrs: 2349636 -> 2345856 (-0.16%); split: -0.23%, +0.06%
   CodeSize: 32796448 -> 32748448 (-0.15%); split: -0.30%, +0.15%

SIMD32:
   Totals from 2081 (78.62% of 2647) affected shaders:
   Instrs: 2609349 -> 2604746 (-0.18%); split: -0.27%, +0.09%
   CodeSize: 37148624 -> 37077824 (-0.19%); split: -0.34%, +0.15%
   Number of spill instructions: 13104 -> 13094 (-0.08%)
   Number of fill instructions: 32677 -> 32662 (-0.05%)

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/42097>
This commit is contained in:
Alyssa Rosenzweig 2026-06-08 13:20:02 -04:00 • committed by Marge Bot
parent e673e68ac3
commit 091e6976d9
2 changed files with 33 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
src/intel/compiler/jay/jay_lower_pre_ra.c
View file

@ -133,8 +133,8 @@ lower_immediates(jay_builder *b, jay_inst *I, struct hash_table_u64 *constants)
}
/* One source supports immediates but the other does not, so swap. */
bool allow_s0 = I->op == JAY_OPCODE_BFE || I->op == JAY_OPCODE_BFN;
unsigned other = allow_s0 ? 1 : 0;
unsigned nr_srcs = jay_num_isa_srcs(I);
unsigned other = nr_srcs == 2 ? 0 : 1;
if (jay_is_imm(I->src[other]) &&
!_mesa_hash_table_u64_search(constants, jay_as_uint(I->src[other]))) {
@ -144,11 +144,37 @@ lower_immediates(jay_builder *b, jay_inst *I, struct hash_table_u64 *constants)
/* Immediates allowed only in certain cases, lower the rest */
jay_foreach_src(I, s) {
if (jay_is_imm(I->src[s])) {
uint32_t imm = jay_as_uint(I->src[s]);
/* In general, one machine source cannot take an immediate */
bool allowed = s < 3 && s != other;
bool last = s == (jay_num_isa_srcs(I) - 1);
bool allowed = s < 2 && (last || I->op == JAY_OPCODE_SEND);
allowed |= (allow_s0 && s == 0 && imm <= UINT16_MAX);
/* Eligible three-source instructions can have exactly one immediate
* (src0 or src2) and it must be 16-bit.
*/
if (nr_srcs == 3) {
unsigned ver = b->shader->devinfo->ver;
allowed &= I->op == JAY_OPCODE_BFN ||
I->op == JAY_OPCODE_ADD3 ||
I->op == JAY_OPCODE_MAD ||
I->op == JAY_OPCODE_DP4A_SS ||
I->op == JAY_OPCODE_DP4A_SU ||
I->op == JAY_OPCODE_DP4A_UU ||
(ver >= 12 && I->op == JAY_OPCODE_BFE);
/* Gen9 does not support 3-src immediates */
allowed &= ver >= 11 &&
!jay_type_is_any_float(I->type) &&
jay_as_uint(I->src[s]) <= UINT16_MAX;
/* Some instructions on some platforms can have at most one
* immediate source. TODO: Refine.
*/
allowed &= ((s == 0) || !jay_is_imm(I->src[0]));
}
/* SENDs have immediate messages descriptors but not payloads */
if (I->op == JAY_OPCODE_SEND) {
allowed = s < 2;
}
if (!allowed) {
I->src[s] = lower_imm_to_ugpr(b, I, s, constants);

2
src/intel/compiler/jay/jay_to_binary.c
View file

@ -95,7 +95,7 @@ to_gen_operand(
/* Immediates have size restrictions but can zero extend */
if (jay_type_size_bits(type) == 64) {
type = jay_type_resize(type, 32);
} else if (I->op == JAY_OPCODE_BFN) {
} else if (jay_num_isa_srcs(I) == 3) {
assert(jay_as_uint(d) <= UINT16_MAX);
type = JAY_TYPE_U16;
}