From 08f9f29d6f091698de2fb02012c122ad4381d4f9 Mon Sep 17 00:00:00 2001 From: Rhys Perry Date: Fri, 5 Mar 2021 10:58:03 +0000 Subject: [PATCH] radv: don't set sx_blend_opt_epsilon for V_028C70_COLOR_10_11_11 Matches radeonsi and PAL. From PAL: // 1 is recommended, but doesn't provide sufficient precision Signed-off-by: Rhys Perry Reviewed-by: Bas Nieuwenhuizen Reviewed-by: Samuel Pitoiset Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4394 Fixes: ed946381564 ("radv: Enable RB+ where possible.") Part-of: (cherry picked from commit 524848707b4f2635a64b42bff1e530f0d6e0c0cd) --- .pick_status.json | 2 +- src/amd/vulkan/radv_cmd_buffer.c | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index 6df06cba469..8f091414c0e 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -283,7 +283,7 @@ "description": "radv: don't set sx_blend_opt_epsilon for V_028C70_COLOR_10_11_11", "nominated": true, "nomination_type": 1, - "resolution": 0, + "resolution": 1, "master_sha": null, "because_sha": "ed9463815644c85c124c72111d96e256db2986b4" }, diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index e34baa26f17..6424255fd4e 100644 --- a/src/amd/vulkan/radv_cmd_buffer.c +++ b/src/amd/vulkan/radv_cmd_buffer.c @@ -1234,10 +1234,8 @@ radv_emit_rbplus_state(struct radv_cmd_buffer *cmd_buffer) break; case V_028C70_COLOR_10_11_11: - if (spi_format == V_028714_SPI_SHADER_FP16_ABGR) { + if (spi_format == V_028714_SPI_SHADER_FP16_ABGR) sx_ps_downconvert |= V_028754_SX_RT_EXPORT_10_11_11 << (i * 4); - sx_blend_opt_epsilon |= V_028758_11BIT_FORMAT << (i * 4); - } break; case V_028C70_COLOR_2_10_10_10: