fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-02-23 01:00:30 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

v3dv: disable Early Z for multisampled 16-bit depth buffers

Browse source 
Besides disabling early-z when a frame is an odd width or height, we
need to disable it if the buffer is 16-bit and multisampled.

Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28009>
This commit is contained in:
Juan A. Suarez Romero 2024-02-26 13:50:17 +01:00 • committed by Marge Bot
parent 33e77c9041
commit 08af5f2703
1 changed files with 13 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/broadcom/vulkan/v3dvx_cmd_buffer.c
View file

@ -1826,10 +1826,11 @@ job_update_ez_state(struct v3dv_job *job,
return false;
}
/* GFXH-1918: the early-z buffer may load incorrect depth values
* if the frame has odd width or height.
/* GFXH-1918: the early-z buffer may load incorrect depth values if the
* frame has odd width or height, or if the buffer is 16-bit and
* multisampled.
*
* So we need to disable EZ in this case.
* So we need to disable EZ in these cases.
*/
const struct v3dv_render_pass_attachment *ds_attachment =
&state->pass->attachments[subpass->ds_attachment.attachment];
@ -1846,6 +1847,15 @@ job_update_ez_state(struct v3dv_job *job,
ds_attachment->desc.storeOp);
if (needs_depth_load) {
if (ds_attachment->desc.format == VK_FORMAT_D16_UNORM &&
ds_attachment->desc.samples != VK_SAMPLE_COUNT_1_BIT) {
perf_debug("Loading depth aspect from a multisampled 16-bit "
"depth buffer disables early-Z tests.\n");
job->first_ez_state = V3D_EZ_DISABLED;
job->ez_state = V3D_EZ_DISABLED;
return false;
}
struct v3dv_framebuffer *fb = state->framebuffer;
if (!fb) {