From 06ae2723d103f485bfdc2d18e3625ce7417ffc9c Mon Sep 17 00:00:00 2001 From: Jason Ekstrand Date: Wed, 2 Jun 2021 23:08:13 -0500 Subject: [PATCH] intel/vec4: Also use MOV_FOR_SCRATCH for swizzle resolves In 2db88679432b, we introduced a new meta-op MOV_FOR_SCRATCH which is identical to MOV except it lets us identify MOVs emitted during spilling so we know not to re-spill those instructions. We emit them from shuffle_for_64bit_data whenever the new for_scratch parameter is true. Unfortunately, we missed the one used for resolving swizzles. Fixes: 2db88679432b "intel/vec4: Don't spill fp64 registers more..." Tested-by: Dave Airlie Reviewed-by: Dave Airlie Part-of: --- src/intel/compiler/brw_vec4_nir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/compiler/brw_vec4_nir.cpp b/src/intel/compiler/brw_vec4_nir.cpp index 4c5dfd00f84..e942cfc9ac4 100644 --- a/src/intel/compiler/brw_vec4_nir.cpp +++ b/src/intel/compiler/brw_vec4_nir.cpp @@ -2177,7 +2177,7 @@ vec4_visitor::shuffle_64bit_data(dst_reg dst, src_reg src, bool for_write, /* Resolve swizzle in src */ if (src.swizzle != BRW_SWIZZLE_XYZW) { dst_reg data = dst_reg(this, glsl_type::dvec4_type); - bld.MOV(data, src); + bld.emit(mov_op, data, src); src = src_reg(data); }