fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-25 12:20:17 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

aco/validate: Validate correct RegisterClasses after lowering to HW instructions

Browse source 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/39107>
This commit is contained in:
Daniel Schürmann 2025-12-30 14:26:12 +01:00 • committed by Marge Bot
parent b087bf2fbf
commit 0674c9d30e
1 changed files with 24 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
src/amd/compiler/aco_validate.cpp
View file

@ -134,14 +134,35 @@ validate_ir(Program* program)
for (Block& block : program->blocks) {
for (aco_ptr<Instruction>& instr : block.instructions) {
if (program->progress < CompilationProgress::after_lower_to_hw) {
for (const Operand& op : instr->operands)
/* Check that register assignment and register class are consistent. */
for (const Operand& op : instr->operands) {
if (program->progress < CompilationProgress::after_lower_to_hw)
check(!op.isTemp() || op.regClass() == program->temp_rc[op.tempId()],
"Operand RC not consistent.", instr.get());
for (const Definition& def : instr->definitions)
if (program->progress >= CompilationProgress::after_ra)
check(op.isFixed(), "Operand without register assignment.", instr.get());
check(!op.hasRegClass() || op.isUndefined() || !op.isFixed() ||
(op.physReg().reg() >= 256
? op.isOfType(RegType::vgpr)
: (op.isOfType(RegType::sgpr) && op.physReg().byte() == 0)),
"Operand RC and assignment not consistent.", instr.get());
}
for (const Definition& def : instr->definitions) {
if (program->progress < CompilationProgress::after_lower_to_hw)
check(!def.isTemp() || def.regClass() == program->temp_rc[def.tempId()],
"Definition RC not consistent.", instr.get());
if (program->progress >= CompilationProgress::after_ra)
check(def.isFixed(), "Definition without register assignment.", instr.get());
check(!def.isFixed() ||
(def.physReg().reg() >= 256
? def.regClass().type() == RegType::vgpr
: (def.regClass().type() == RegType::sgpr && def.physReg().byte() == 0)),
"Definition RC and assignment not consistent.", instr.get());
}
const aco_alu_opcode_info& opcode_info = instr_info.alu_opcode_infos[(int)instr->opcode];