fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-09 02:28:10 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

v3d: Fix temporary leaks of temp_registers and when spilling.

Browse source 
On each iteration of successfully spilling a reg, we'd allocate another
copy of temp_registers, and when decrementing thread conut we'd allocate
another copy of the graph.  These all got cleaned up on freeing the
compile.
This commit is contained in:
Eric Anholt 2019-02-26 10:46:36 -08:00
parent faf9e40f35
commit 060979a380
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/broadcom/compiler/vir_register_allocate.c
View file

@ -394,8 +394,6 @@ v3d_register_allocate(struct v3d_compile *c, bool *spilled)
struct node_to_temp_map map[c->num_temps];
uint32_t temp_to_node[c->num_temps];
uint8_t class_bits[c->num_temps];
struct qpu_reg *temp_registers = calloc(c->num_temps,
sizeof(*temp_registers));
int acc_nodes[ACC_COUNT];
struct v3d_ra_select_callback_data callback_data = {
.next_acc = 0,
@ -594,18 +592,19 @@ v3d_register_allocate(struct v3d_compile *c, bool *spilled)
if (node != -1) {
v3d_spill_reg(c, map[node].temp);
ralloc_free(g);
/* Ask the outer loop to call back in. */
*spilled = true;
return NULL;
}
}
free(temp_registers);
ralloc_free(g);
return NULL;
}
struct qpu_reg *temp_registers = calloc(c->num_temps,
sizeof(*temp_registers));
for (uint32_t i = 0; i < c->num_temps; i++) {
int ra_reg = ra_get_node_reg(g, temp_to_node[i]);
if (ra_reg < PHYS_INDEX) {