fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-01 18:58:10 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Coverity #476: Avoid walking off the end of ->vtx.attrsz, it's declared to

Browse source 
be _TNL_ATTRIB_MAX long so that's not a valid index (woo zero based
indexing).

This code still looks wrong though, the asymmetry between _tnl_copy_to_current
and _tnl_copy_from_current has me worried.
This commit is contained in:
Adam Jackson 2006-04-02 23:51:30 +00:00
parent b3208c2de9
commit 05ddc4a6c5
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/mesa/tnl/t_vtx_api.c
View file

@ -194,7 +194,7 @@ static void _tnl_copy_from_current( GLcontext *ctx )
tnl->vtx.CurrentFloatEdgeFlag =
(GLfloat)ctx->Current.EdgeFlag;
for (i = _TNL_ATTRIB_POS+1 ; i <= _TNL_ATTRIB_MAX ; i++)
for (i = _TNL_ATTRIB_POS+1 ; i < _TNL_ATTRIB_MAX ; i++)
switch (tnl->vtx.attrsz[i]) {
case 4: tnl->vtx.attrptr[i][3] = tnl->vtx.current[i][3];
case 3: tnl->vtx.attrptr[i][2] = tnl->vtx.current[i][2];