fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-04-23 20:20:38 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

freedreno/pps: loop countables by references

Browse source 
Mainly to get rid of alloc/free in collect_countables.  Sampling at 1ms,
perf becomes

   - 22.75% pps::FreedrenoDriver::collect_countables
           22.59% pps::FreedrenoDriver::Countable::collect

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19427>
This commit is contained in:
Chia-I Wu 2022-10-31 14:27:08 -07:00 • committed by Marge Bot
parent 86553cd771
commit 05a4d3f380
2 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/freedreno/ds/fd_pps_driver.cc
View file

@ -403,7 +403,7 @@ FreedrenoDriver::configure_counters(bool reset, bool wait)
(enum fd_ringbuffer_flags)(FD_RINGBUFFER_PRIMARY | FD_RINGBUFFER_GROWABLE);
struct fd_ringbuffer *ring = fd_submit_new_ringbuffer(submit, 0x1000, flags);
for (auto countable : countables)
for (const auto &countable : countables)
countable.configure(ring, reset);
struct fd_submit_fence fence = {};
@ -428,7 +428,7 @@ FreedrenoDriver::collect_countables()
{
last_dump_ts = perfetto::base::GetBootTimeNs().count();
for (auto countable : countables)
for (const auto &countable : countables)
countable.collect();
}
@ -476,7 +476,7 @@ FreedrenoDriver::init_perfcnt()
state.resize(next_countable_id);
for (auto countable : countables)
for (const auto &countable : countables)
countable.resolve();
info = fd_dev_info(dev_id);
@ -593,7 +593,7 @@ FreedrenoDriver::Countable::Countable(FreedrenoDriver *d, std::string name)
/* Emit register writes on ring to configure counter/countable muxing: */
void
FreedrenoDriver::Countable::configure(struct fd_ringbuffer *ring, bool reset)
FreedrenoDriver::Countable::configure(struct fd_ringbuffer *ring, bool reset) const
{
const struct fd_perfcntr_countable *countable = d->state[id].countable;
const struct fd_perfcntr_counter *counter = d->state[id].counter;
@ -624,7 +624,7 @@ FreedrenoDriver::Countable::configure(struct fd_ringbuffer *ring, bool reset)
/* Collect current counter value and calculate delta since last sample: */
void
FreedrenoDriver::Countable::collect()
FreedrenoDriver::Countable::collect() const
{
const struct fd_perfcntr_counter *counter = d->state[id].counter;
@ -639,7 +639,7 @@ FreedrenoDriver::Countable::collect()
/* Resolve the countable and assign next counter from it's group: */
void
FreedrenoDriver::Countable::resolve()
FreedrenoDriver::Countable::resolve() const
{
for (unsigned i = 0; i < d->num_perfcntrs; i++) {
const struct fd_perfcntr_group *g = &d->perfcntrs[i];

6
src/freedreno/ds/fd_pps_driver.h
View file

@ -103,9 +103,9 @@ private:
operator int64_t() const { return get_value(); };
void configure(struct fd_ringbuffer *ring, bool reset);
void collect();
void resolve();
void configure(struct fd_ringbuffer *ring, bool reset) const;
void collect() const;
void resolve() const;
private: