fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-02-22 16:20:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

ir3/ra: Don't swap killed sources for early-clobber destination

Browse source 
We have an optimization to try to swap regular live intervals with
killed sources when evicting them fails in order to make a contiguous
space for the destination to fit in, but this doesn't work when the
destination is early-clobber.

Fixes
dEQP-GLES31.functional.synchronization.inter_invocation.image_atomic_read_write
on a650+.

Fixes: d4b5d2a ("ir3/ra: Use killed sources in register eviction")
Closes: #8886
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26004>
This commit is contained in:
Connor Abbott 2023-11-02 12:03:35 +01:00 • committed by Marge Bot
parent aba837ef71
commit 04ffef15da
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/freedreno/ci/freedreno-a660-fails.txt
View file

@ -5,10 +5,6 @@ KHR-GL46.shader_image_load_store.basic-allTargets-store,Fail
KHR-GL46.shader_subroutine.control_flow_and_returned_subroutine_values_used_as_subroutine_input,Fail
KHR-GL46.tessellation_shader.single.max_patch_vertices,Fail
# https://gitlab.freedesktop.org/mesa/mesa/-/issues/8886
dEQP-GLES31.functional.synchronization.inter_invocation.image_atomic_read_write,Crash
# Fails when TU_DEBUG=forcebin is set
gmem-dEQP-VK.spirv_assembly.instruction.graphics.variable_pointers.graphics.writes_two_buffers_vert,Fail

8
src/freedreno/ir3/ir3_ra.c
View file

@ -879,9 +879,13 @@ try_evict_regs(struct ra_ctx *ctx, struct ra_file *file,
if (evicted)
continue;
/* If we couldn't evict this range, we may be able to swap it with a
* killed range to acheive the same effect.
/* If we couldn't evict this range, but the register we're allocating is
* allowed to overlap with a killed range, then we may be able to swap it
* with a killed range to acheive the same effect.
*/
if (is_early_clobber(reg) || is_source)
return false;
foreach_interval (killed, file) {
if (!killed->is_killed)
continue;