fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-03-17 01:40:36 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

u_debug_stack: Lock around stack dumps to prevent interleaving

Browse source 
Reviewed-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Sil Vilerino <sivileri@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16182>
This commit is contained in:
Jesse Natalie 2022-04-26 16:25:13 -07:00 • committed by Marge Bot
parent 303c2754a3
commit 0474bbcfb9
1 changed files with 21 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
src/util/u_debug_stack.c
View file

@ -36,6 +36,7 @@
#include "u_debug_symbol.h"
#include "u_debug_stack.h"
#include "pipe/p_config.h"
#include "c11/threads.h"
#if defined(HAVE_LIBUNWIND)
@ -186,7 +187,6 @@ debug_backtrace_print(FILE *f,
#include <windows.h>
#endif
/**
* Capture stack backtrace.
*
@ -296,17 +296,32 @@ debug_backtrace_capture(struct debug_stack_frame *backtrace,
}
static mtx_t backtrace_mutex;
static void
initialize_backtrace_mutex()
{
static bool first = true;
if (first) {
(void)mtx_init(&backtrace_mutex, mtx_plain);
first = false;
}
}
void
debug_backtrace_dump(const struct debug_stack_frame *backtrace,
unsigned nr_frames)
{
unsigned i;
initialize_backtrace_mutex();
mtx_lock(&backtrace_mutex);
for (i = 0; i < nr_frames; ++i) {
if (!backtrace[i].function)
break;
debug_symbol_print(backtrace[i].function);
}
mtx_unlock(&backtrace_mutex);
}
@ -317,6 +332,8 @@ debug_backtrace_print(FILE *f,
{
unsigned i;
initialize_backtrace_mutex();
mtx_lock(&backtrace_mutex);
for (i = 0; i < nr_frames; ++i) {
const char *symbol;
if (!backtrace[i].function)
@ -325,6 +342,8 @@ debug_backtrace_print(FILE *f,
if (symbol)
fprintf(f, "%s\n", symbol);
}
fflush(f);
mtx_unlock(&backtrace_mutex);
}
#endif /* HAVE_LIBUNWIND */