fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-25 15:10:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

glsl: Skip "unsized arrays aren't allowed" check for TCS/TES/GS vars.

Browse source 
Fixes ESEXT-CTS.draw_elements_base_vertex_tests.AEP_shader_stages and
ESEXT-CTS.texture_cube_map_array.texture_size_tesselation_con_sh.

Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu>
This commit is contained in:
Kenneth Graunke 2016-09-15 02:10:23 -07:00
parent 6ed05fa4cb
commit 04026b43c8
1 changed files with 27 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
src/compiler/glsl/ast_to_hir.cpp
View file

@ -5127,7 +5127,33 @@ ast_declarator_list::hir(exec_list *instructions,
const glsl_type *const t = (earlier == NULL)
? var->type : earlier->type;
if (t->is_unsized_array())
/* Skip the unsized array check for TCS/TES/GS inputs & TCS outputs.
*
* The GL_OES_tessellation_shader spec says about inputs:
*
* "Declaring an array size is optional. If no size is specified,
* it will be taken from the implementation-dependent maximum
* patch size (gl_MaxPatchVertices)."
*
* and about TCS outputs:
*
* "If no size is specified, it will be taken from output patch
* size declared in the shader."
*
* The GL_OES_geometry_shader spec says:
*
* "All geometry shader input unsized array declarations will be
* sized by an earlier input primitive layout qualifier, when
* present, as per the following table."
*/
const bool implicitly_sized =
(var->data.mode == ir_var_shader_in &&
state->stage >= MESA_SHADER_TESS_CTRL &&
state->stage <= MESA_SHADER_GEOMETRY) ||
(var->data.mode == ir_var_shader_out &&
state->stage == MESA_SHADER_TESS_CTRL);
if (t->is_unsized_array() && !implicitly_sized)
/* Section 10.17 of the GLSL ES 1.00 specification states that
* unsized array declarations have been removed from the language.
* Arrays that are sized using an initializer are still explicitly