fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-02-04 19:20:38 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

anv: re-alloc push constants after secondary command buffers

Browse source 
If the secondary command buffer executed used push constants on a
different set of stages than the primary is using, we may end up not
reallocating them for the primary, getting misrender artifacts at best,
or a nice GPU hang at worst.

Fixes the tests from a CTS from the future:
dEQP-VK.dynamic_rendering.random.*

Cc: mesa-stable

Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16439>
(cherry picked from commit 2e46f38902)
This commit is contained in:
Iván Briano 2022-05-09 18:30:20 -07:00 • committed by Dylan Baker
parent 0b90d3dc58
commit 03d5e496d9
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -211,7 +211,7 @@
"description": "anv: re-alloc push constants after secondary command buffers",
"nominated": true,
"nomination_type": 0,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": null
},

1
src/intel/vulkan/genX_cmd_buffer.c
View file

@ -1995,6 +1995,7 @@ genX(CmdExecuteCommands)(
primary->state.current_l3_config = NULL;
primary->state.current_hash_scale = 0;
primary->state.gfx.dirty |= ANV_CMD_DIRTY_DYNAMIC_ALL;
primary->state.gfx.push_constant_stages = 0;
/* Each of the secondary command buffers will use its own state base
* address. We need to re-emit state base address for the primary after