fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-24 17:30:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

glsl: don't validate binding when its not needed

Browse source 
Checking that the flag has been set is all the validation thats
needed here.

Also not calling the binding validation function will make things
much simpler when adding compile time constant support as we
won't need to resolve the binding value.

Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
This commit is contained in:
Timothy Arceri 2015-11-13 11:41:52 +11:00 • committed by Timothy Arceri
parent 4f4ca6b90a
commit 03bbddd139
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/glsl/ast_to_hir.cpp
View file

@ -6133,8 +6133,11 @@ ast_process_struct_or_iface_block_members(exec_list *instructions,
"uniform block");
}
if (qual->flags.q.explicit_binding)
validate_binding_qualifier(state, &loc, decl_type, qual);
if (qual->flags.q.explicit_binding) {
_mesa_glsl_error(&loc, state,
"binding layout qualifier cannot be applied "
"to struct or interface block members");
}
if (qual->flags.q.std140 ||
qual->flags.q.std430 ||